786809 - (b2g-stk) B2G RIL: typo in Stk

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

There are typos in StkCommandParamsFactory.processDisplayText and StkProactiveCmdHelper.retrieceDefaultText I didn't notice in the first place.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch to fix typo

Hi, philikon:
I spot some typos I made in stk patches.

sorry for my carelessness.

Comment 2

[Philipp von Weitershausen [:philikon]]

Comment on attachment 656595 [details] [diff] [review]
Patch to fix typo

Review of attachment 656595 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ -5480,5 @@
>          commandQualifier: cmdDetails.commandQualifier,
>          resultCode: STK_RESULT_REQUIRED_VALUES_MISSING});
>        throw new Error("Stk Display Text: Required value missing : Text String");
>      }
> -    textMsg.text = ctlv.value.text;

This line occurs two more times throughout ril_worker.js... should those also be fixed?

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch to fix typo. v2

Hi, philikon
Yes, you're right. more typos.....

Thanks for catching that.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/87916fa5d94f

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/87916fa5d94f