786831 - B2G RIL: Simplify nsIDOMMozIccManager::sendStkResponse

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Philipp von Weitershausen [:philikon]]

Instead of

    icc.sendStkResponse({
      commandNumber: command.commandNumber,
      typeOfCommand: command.typeOfCommand,
      commandQualifier: command.commandQualifier,
      resultCode: icc.STK_RESULT_OK,
      ...
    });

I think it would be simpler if we did

    icc.sendStkResponse(command, {
      resultCode: icc.STK_RESULT_OK,
      ...
    });

since the command stuff is always required.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Update IDL

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: Update IccManager

Hi, smaug
There's a small update about IccManager, 
Could you review this patch for me ?

Thanks

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 3: Update RIL

Hi, philikon:
one more patch,
this is about update RIL implementaions

Thanks

Comment 4

[Philipp von Weitershausen [:philikon]]

Comment on attachment 656707 [details] [diff] [review]
Part 1: Update IDL

Review of attachment 656707 [details] [diff] [review]:
-----------------------------------------------------------------

I'm going to go out on a limb here and claim that we won't need superreview for this.

Comment 5

[Philipp von Weitershausen [:philikon]]

Comment on attachment 656710 [details] [diff] [review]
Part 3: Update RIL

Review of attachment 656710 [details] [diff] [review]:
-----------------------------------------------------------------

<3

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Update IDL

Update patch comments.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: Update IccManager

Rebase

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/98b94d18373e
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ea41d5679c4
https://hg.mozilla.org/integration/mozilla-inbound/rev/604c5f59c5e0

Guys,
Thanks for your quick review.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/98b94d18373e
https://hg.mozilla.org/mozilla-central/rev/7ea41d5679c4
https://hg.mozilla.org/mozilla-central/rev/604c5f59c5e0