Closed Bug 786831 Opened 9 years ago Closed 9 years ago

B2G RIL: Simplify nsIDOMMozIccManager::sendStkResponse

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: philikon, Assigned: allstars.chh)

References

Details

Attachments

(3 files, 2 obsolete files)

Instead of

    icc.sendStkResponse({
      commandNumber: command.commandNumber,
      typeOfCommand: command.typeOfCommand,
      commandQualifier: command.commandQualifier,
      resultCode: icc.STK_RESULT_OK,
      ...
    });

I think it would be simpler if we did

    icc.sendStkResponse(command, {
      resultCode: icc.STK_RESULT_OK,
      ...
    });

since the command stuff is always required.
Assignee: nobody → allstars.chh
Status: NEW → ASSIGNED
Attached patch Part 1: Update IDL (obsolete) — Splinter Review
Attachment #656707 - Flags: review?(philipp)
Attached patch Part 2: Update IccManager (obsolete) — Splinter Review
Hi, smaug
There's a small update about IccManager, 
Could you review this patch for me ?

Thanks
Attachment #656708 - Flags: review?(bugs)
Hi, philikon:
one more patch,
this is about update RIL implementaions

Thanks
Attachment #656710 - Flags: review?(philipp)
Attachment #656708 - Flags: review?(bugs) → review+
Comment on attachment 656707 [details] [diff] [review]
Part 1: Update IDL

Review of attachment 656707 [details] [diff] [review]:
-----------------------------------------------------------------

I'm going to go out on a limb here and claim that we won't need superreview for this.
Attachment #656707 - Flags: review?(philipp) → review+
Comment on attachment 656710 [details] [diff] [review]
Part 3: Update RIL

Review of attachment 656710 [details] [diff] [review]:
-----------------------------------------------------------------

<3
Attachment #656710 - Flags: review?(philipp) → review+
Update patch comments.
Attachment #656707 - Attachment is obsolete: true
Rebase
Attachment #656708 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.