786842 - Fix replaceBrs() typo for checking whitespace

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Reader View, defect, P1)

Description

[Brian Nicholson (:bnicholson)]

replaceBrs() looks for whitespace between <br> nodes to collapse them. Right now, we have:

    !whitespace.test(next.textContent)

which continues the loop if the sibling is *not* whitespace.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Fix replaceBrs() typo for checking whitespace

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 656629 [details] [diff] [review]
Fix replaceBrs() typo for checking whitespace

Review of attachment 656629 [details] [diff] [review]:
-----------------------------------------------------------------

Does this fix the problem I was seeing mobile.washingtonpost.com?

Comment 3

[Brian Nicholson (:bnicholson)]

(In reply to Lucas Rocha (:lucasr) from comment #2)
> Comment on attachment 656629 [details] [diff] [review]
> Fix replaceBrs() typo for checking whitespace
> 
> Review of attachment 656629 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Does this fix the problem I was seeing mobile.washingtonpost.com?

I haven't tried reproducing that problem, but I hope so.

http://hg.mozilla.org/integration/mozilla-inbound/rev/ec63d3b35553

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 656629 [details] [diff] [review]
Fix replaceBrs() typo for checking whitespace

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 777966
User impact if declined: articles may have extra space between them
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: none

Comment 5

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/ec63d3b35553

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 656629 [details] [diff] [review]
Fix replaceBrs() typo for checking whitespace

[Triage Comment]
Low risk Reader Mode readability fix. Approved for branches.

Comment 7

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/d7c97f004f54

Comment 8

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/releases/mozilla-beta/rev/3e3adfa92d20

Comment 9

[Cristian Nicolae (:xti)]

Changes were applied on all branches. Closing bug as verified fixed.

--
Device: Galaxy Note
OS: Android 4.0.4