Closed Bug 786854 Opened 12 years ago Closed 12 years ago

"ASSERTION: Empty string?" with empty background attribute

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: jruderman, Assigned: khuey)

References

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

Attached file testcase
###!!! ASSERTION: Empty string?: 'len || Type() == eCSSStyleRule || Type() == eEnum', file content/base/src/nsAttrValue.cpp, line 1581

Maybe a regression from bug 783162?
Attached file stack trace
Assignee: nobody → khuey
Attached patch PatchSplinter Review
I thought about just adjusting the assertion, but I decided to just stop handling background="" instead.
Attachment #657961 - Flags: review?(bzbarsky)
Comment on attachment 657961 [details] [diff] [review]
Patch

And faster code, too! I should have thought of this during the initial review....

r=me
Attachment #657961 - Flags: review?(bzbarsky) → review+
Flags: in-testsuite+
Target Milestone: --- → mozilla18
https://hg.mozilla.org/mozilla-central/rev/ec37fd0db002
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: