786985 - Slowly opened top-level windows cause failures on startup because we assume those are already loaded

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

With bug 775811 fixed we now start Mozmill early in the start-up process. This works fine in opt builds but fails in debug builds as I have seen now while debugging bug 786852. Startup takes a long time for debug builds and the first top-level window will show-up way later.

But Mozmill wants to directly start the test instead of waiting for the first top-level window. We have to make sure that this will not happen. It shouldn't be too hard to implement.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As it looks like our initial window handling code for top-level windows is broken and can result in inconsistent results where we assume a window has already been finished loading. This will break the first test with a failure like:

"message": "this.docShell is null", 
"fileName": "chrome://global/content/bindings/browser.xml", 
"name": "TypeError", 
"lineNumber": 323

To prevent this we cannot assume the window is already loaded but have to take the current value of the document's readyState.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

Comment 3

[cmtalbert]

Comment on attachment 741862 [details] [diff] [review]
Patch v1

Review of attachment 741862 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch.  r=me

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

https://github.com/mozilla/mozmill/commit/e29a9836aec322ede09b9af48e7390f204917a21