Closed
Bug 786985
Opened 12 years ago
Closed 12 years ago
Slowly opened top-level windows cause failures on startup because we assume those are already loaded
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Keywords: regression, Whiteboard: [mozmill-2.0][ateamtrack: p=mozmill q=2013q2 m=1])
Attachments
(1 file)
1.67 KB,
patch
|
cmtalbert
:
review+
|
Details | Diff | Splinter Review |
With bug 775811 fixed we now start Mozmill early in the start-up process. This works fine in opt builds but fails in debug builds as I have seen now while debugging bug 786852. Startup takes a long time for debug builds and the first top-level window will show-up way later.
But Mozmill wants to directly start the test instead of waiting for the first top-level window. We have to make sure that this will not happen. It shouldn't be too hard to implement.
Assignee | ||
Updated•12 years ago
|
Whiteboard: [mozmill-2.0?] → [mozmill-2.0+]
Assignee: hskupin → nobody
Whiteboard: [mozmill-2.0+] → [mozmill-2.1?]
Assignee | ||
Comment 1•12 years ago
|
||
As it looks like our initial window handling code for top-level windows is broken and can result in inconsistent results where we assume a window has already been finished loading. This will break the first test with a failure like:
"message": "this.docShell is null",
"fileName": "chrome://global/content/bindings/browser.xml",
"name": "TypeError",
"lineNumber": 323
To prevent this we cannot assume the window is already loaded but have to take the current value of the document's readyState.
Assignee: nobody → hskupin
Whiteboard: [mozmill-2.1?] → [mozmill-2.0?]
Assignee | ||
Updated•12 years ago
|
Summary: Debug builds cause Mozmill to fail because no top-level window has been opened yet → Slowly opened top-level windows cause failures on startup because we assume those are already loaded
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #741862 -
Flags: review?(ctalbert)
Comment on attachment 741862 [details] [diff] [review]
Patch v1
Review of attachment 741862 [details] [diff] [review]:
-----------------------------------------------------------------
Good catch. r=me
Attachment #741862 -
Flags: review?(ctalbert) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [mozmill-2.0?] → [mozmill-2.0]
Assignee | ||
Updated•12 years ago
|
Whiteboard: [mozmill-2.0] → [mozmill-2.0][ateamtrack: p=mozmill q=2013q2 m=1]
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•