Closed Bug 786997 Opened 12 years ago Closed 12 years ago

[responsive mode] the page background should be the same as the standalone image page

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 18

People

(Reporter: paul, Unassigned)

Details

(Whiteboard: [good first bug][mentor=paul][lang=css][fixed-in-fx-team])

Attachments

(1 file, 1 obsolete file)

Patch.V2
2.28 KB, patch
paul
: review+
Details | Diff | Splinter Review
And we might want to remove the inner shadow too.
To see the "standalone image page", open any image in Firefox. You'll see a dark-noised background.
Hi Paul, I am interested in working on this bug. Could you please guide me on getting started with it. Thanks.
Sure! When you start the responsive mode, the background is blue-ish, and has a inset shadow. http://mxr.mozilla.org/mozilla-central/source/browser/themes/pinstripe/browser.css#3207 http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/browser.css#3170 http://mxr.mozilla.org/mozilla-central/source/browser/themes/gnomestripe/browser.css#2490 We want to have the same background as the "top level image document" (which is the page you see when you open a standalone iamge). You can see the code for example here: http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/global/TopLevelImageDocument.css This probably just mean changing the background color (not the background image) and removing the inset shadow.
Hi, I am interested to contribute in this bug. Thanks!
Sure. See comment 3.
Attached patch Patch.V1 (obsolete) — — Splinter Review
Attachment #658486 - Flags: review?
Comment on attachment 658486 [details] [diff] [review] Patch.V1 Changed background color in the browser.css file for the gnomestripe, pinstripe, and winstripe themes.
Attachment #658486 - Flags: review? → review?(paul)
Comment on attachment 658486 [details] [diff] [review] Patch.V1 Looks right. Thank you :) You might want to update your repo though (the code has changed). Also, can you remove the inset shadow as well?
Attachment #658486 - Flags: review?(paul)
Attached patch Patch.V2 — — Splinter Review
Removed inset shadow and created patch against updated repo.
Attachment #658486 - Attachment is obsolete: true
Attachment #658499 - Flags: review?(paul)
Comment on attachment 658499 [details] [diff] [review] Patch.V2 Review of attachment 658499 [details] [diff] [review]: ----------------------------------------------------------------- Thank you!
Attachment #658499 - Flags: review?(paul) → review+
Whiteboard: [good first bug][mentor=paul][lang=css] → [good first bug][mentor=paul][lang=css][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/a3f35885f107
Whiteboard: [good first bug][mentor=paul][lang=css][land-in-fx-team] → [good first bug][mentor=paul][lang=css][fixed-in-fx-team]
https://tbpl.mozilla.org/?rev=8b46964e55c9
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: