787019 - Improve sut_tools/verify.py strings "WARNING: Unable to ping tegra after 5 try" and friends

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Ed Morley [:emorley]]

eg from:
https://tbpl.mozilla.org/php/getParsedLog.php?id=14833402&tree=Mozilla-Aurora
(Bug 781419)

{
========= Started Running verify.py failed (results: 2, elapsed: 7 mins, 45 secs) (at 2012-08-30 03:54:36.229795) =========
python /builds/sut_tools/verify.py
 in dir /builds/tegra-217/test/build (timeout 1200 secs)
 watching logfiles {}
 argv: ['python', '/builds/sut_tools/verify.py']
 environment:
  HOME=/Users/cltbld
  PATH=/opt/local/bin:/opt/local/sbin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11/bin
  PWD=/builds/tegra-217/test/build
  SUT_IP=10.250.51.57
  SUT_NAME=tegra-217
  __CF_USER_TEXT_ENCODING=0x1F5:0:0
 closing stdin
 using PTY: False
DEBUG: updateSUT: Using tegra 'tegra-217' found in env variable
INFO: Using tegra 'tegra-217' found in env variable
INFO: attempting to ping tegra
INFO: Unable to ping tegra after 1 try. Sleeping for 90s then retrying
INFO: Unable to ping tegra after 2 try. Sleeping for 90s then retrying
INFO: Unable to ping tegra after 3 try. Sleeping for 90s then retrying
INFO: Unable to ping tegra after 4 try. Sleeping for 90s then retrying
WARNING: Unable to ping tegra after 5 try
program finished with exit code 1
}

We should just get rid of the counts on the previous steps, since they are redundant & on the warning, make try plural (and maybe pick a better verb).

Nitpicky, but I see this every time bug 781419 occurs.

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Output will now be:

INFO: attempting to ping tegra
INFO: Unable to ping tegra. Sleeping for 90s then retrying
INFO: Unable to ping tegra. Sleeping for 90s then retrying
INFO: Unable to ping tegra. Sleeping for 90s then retrying
INFO: Unable to ping tegra. Sleeping for 90s then retrying
WARNING: Unable to ping tegra after 5 attempts

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 656828 [details] [diff] [review]
Patch v1

Land at your convenience, but leave the bug open until I deploy.

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 656828 [details] [diff] [review]
Patch v1

err actually, while this is fine, its not the lines you want to edit for your c#0

Comment 4

[Justin Wood (:Callek)]

You want the lines at http://mxr.mozilla.org/build/source/tools/sut_tools/verify.py#49  (I endorse doing what is in your patch as well, if you like)

Comment 5

[Ed Morley [:emorley]]

Attachment: Patch v2

Ah, indeed - good spot :-)

Comment 6

[Ed Morley [:emorley]]

Comment on attachment 657939 [details] [diff] [review]
Patch v2

Thank you :-)

http://hg.mozilla.org/build/tools/rev/7eb825f82f77

Comment 7

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=15124997&tree=Mozilla-Inbound
236