Closed
Bug 787090
Opened 13 years ago
Closed 13 years ago
Fix the implementation of launch() when there is an entry point.
Categories
(Core Graveyard :: DOM: Apps, defect)
Core Graveyard
DOM: Apps
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla18
People
(Reporter: fabrice, Unassigned)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
1.38 KB,
patch
|
vingtetun
:
review+
|
Details | Diff | Splinter Review |
The current implementation is doing strange things, and that leads to gaia using workarounds.
|
Reporter | |
Updated•13 years ago
|
OS: Linux → All
QA Contact: fabrice
Hardware: x86_64 → All
|
|
Reporter | |
Comment 1•13 years ago
|
||
Comment on attachment 656890 [details] [diff] [review]
patch
We tested with Alberto, and he has the gaia fixes ready.
Attachment #656890 -
Flags: review?(21)
|
|
Reporter | |
Updated•13 years ago
|
Summary: Fix the implementaion of launch() when there is an entry point. → Fix the implementation of launch() when there is an entry point.
|
||
Comment 2•13 years ago
|
||
Comment on attachment 656890 [details] [diff] [review]
patch
Review of attachment 656890 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/apps/src/Webapps.jsm
@@ +1033,2 @@
> let startPoint = aStartPoint || "";
> + if (startPoint === "") {
nit: no need for the intermediate variable
Attachment #656890 -
Flags: review?(21) → review+
|
|
Reporter | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
|
|
||
Updated•13 years ago
|
Whiteboard: [qa-]
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•