Closed Bug 787090 Opened 12 years ago Closed 12 years ago

Fix the implementation of launch() when there is an entry point.

Categories

(Core Graveyard :: DOM: Apps, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: fabrice, Unassigned)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch patchSplinter Review
The current implementation is doing strange things, and that leads to gaia using workarounds.
OS: Linux → All
QA Contact: fabrice
Hardware: x86_64 → All
Comment on attachment 656890 [details] [diff] [review]
patch

We tested with Alberto, and he has the gaia fixes ready.
Attachment #656890 - Flags: review?(21)
Summary: Fix the implementaion of launch() when there is an entry point. → Fix the implementation of launch() when there is an entry point.
Comment on attachment 656890 [details] [diff] [review]
patch

Review of attachment 656890 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/apps/src/Webapps.jsm
@@ +1033,2 @@
>      let startPoint = aStartPoint || "";
> +    if (startPoint === "") {

nit: no need for the intermediate variable
Attachment #656890 - Flags: review?(21) → review+
https://hg.mozilla.org/mozilla-central/rev/fc797ab55193
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Whiteboard: [qa-]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: