787175 - B2G RIL: Use system messages to notify proactive commands

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Philipp von Weitershausen [:philikon]]

Like bug 782488 and bug 782489, but for the STK. We want to notify the Settings app (or wherever the STK UI will be implemented).

Yoshi, can you take this? Thanks!

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: WIP - Patch to send system message

Hi, philikon
This patch is based on patch from Bug 787064(already r+),
can you give me some feedback about this?

Thanks

Comment 2

[Philipp von Weitershausen [:philikon]]

Comment on attachment 657112 [details] [diff] [review]
WIP - Patch to send system message

Review of attachment 657112 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comments below addressed.

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +94,5 @@
>  });
>  
> +XPCOMUtils.defineLazyGetter(this, "gSystemMessenger", function() {
> +  return Cc["@mozilla.org/system-message-internal;1"].getService(Ci.nsISystemMessagesInternal);
> +});

Please use XPCOM.defineLazyServiceGetter.

@@ +456,5 @@
>          this.handleStkProactiveCommand(message);
>          break;
>        case "stksessionend":
>          ppmm.broadcastAsyncMessage("RIL:StkSessionEnd", null);
> +        gSystemMessenger.broadcastMessage("stksessionend", null);

Why would we need to send this as a system message? I would imagine that by the time this event gets dispatched, the relevant app is already long active...

@@ +1032,5 @@
>    },
>  
>    handleStkProactiveCommand: function handleStkProactiveCommand(message) {
>      debug("handleStkProactiveCommand " + JSON.stringify(message));
> +    gSystemMessenger.broadcastMessage("stkcommand", message);

Maybe prefix the message name with "icc-"?

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch to send system message

Address to philikon's comments:
- add r=philikon,
- remove system message for stksessionend
- add icc- prefix for stkcommad.

Thanks

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/15eacf38a2fb

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/15eacf38a2fb