787190 - ubuntu system wide manual proxy settings not honored

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Patrick McManus [:mcmanus]]

set firefox proxy settings to "system" and use ubuntu 12.04 to set system wide manual proxy.

e.g. ubuntu-system->network.. method = manual.. http proxy = IP port = PORT

this is not picked up in firefox.

If you set method to "automatic" and provide a valid pac file it is picked up in firefox.

I tracked this down to firefox requiring gconf values of (/system/proxy/mode == manual) AND (/system/http_proxy/use_http_proxy == true)

the right logic is mode==manual OR use_http_proxy==true.. ubuntu 12.04 only sets the mode.

patch forthcoming

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: patch 0

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 657002 [details] [diff] [review]
patch 0

-  if (!IsProxyMode("manual") || !masterProxySwitch) {
+  if (!(IsProxyMode("manual") || masterProxySwitch)) {

I think this would be easier to read as:
  if (!IsProxyMode("manual") && !masterProxySwitch) {

Comment 3

[Patrick McManus [:mcmanus]]

https://tbpl.mozilla.org/?tree=Try&rev=177dd107067b

Comment 4

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c740837c448b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c740837c448b