787225 - Skia symbols not exported from libgkmedias.dll

Status: RESOLVED WONTFIX

(Core :: Graphics, defect)

Description

[Joe Drew (not getting mail)]

Because we compile Skia as part of the external gkmedias DLL, we need to export its symbols to use them from other code.

I believe this will be solved if we globally define SKIA_DLL and, while compiling Skia itself, define SKIA_IMPLEMENTATION.

Comment 1

[George Wright (:gw280) (needinfo me!)]

Attachment: Fix DLL exports

Untested as I don't have easy access to a Win32 box. Can you test it?

Comment 2

[Joe Drew (not getting mail)]

Attachment: define SKIA_DLL in mozilla-config.h

In order to get SKIA_DLL defined across all of the code, the only reliable way is to have it in mozilla-config.h.

Comment 3

[Joe Drew (not getting mail)]

Attachment: define SKIA_DLL in mozilla-config.h

Whoops, qrefreshed into the wrong patch.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 657423 [details] [diff] [review]
define SKIA_DLL in mozilla-config.h

Review of attachment 657423 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +7710,5 @@
>  MOZ_ENABLE_SKIA=1,
>  MOZ_ENABLE_SKIA=)
>  
> +if test "$MOZ_ENABLE_SKIA"; then
> +    AC_DEFINE(SKIA_DLL)

That's going to export the symbols on mac and linux, isn't it?

Comment 5

[Joe Drew (not getting mail)]

It'll make the Skia classes have this attribute:

        #define SK_API __attribute__((visibility("default")))

Is that a problem?

Comment 6

[George Wright (:gw280) (needinfo me!)]

It might increase dlopen times for libxul, I guess?

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 657423 [details] [diff] [review]
define SKIA_DLL in mozilla-config.h

Review of attachment 657423 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I don't think you want to do that. We should do this on Windows only.

Comment 8

[Joe Drew (not getting mail)]

This isn't necessary after all.