787289 - Don't copy useless info from about:support

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Chris Ilias [:cilias]]

Right now, if you go to Help > Troubleshooting Information (or about:support), and click on [Copy all to clipboard], the text in the clipboard includes info that doesn't need to be copy and pasted.

These include:

        Profile Folder

          Show in Finder

        Enabled Plugins

          about:plugins

        Build Configuration

          about:buildconfig

        Crash Reports

          about:crashes

        Memory Use

          about:memory


Those are just links to other pages (and the profile folder), and don't need to be copied/pasted.

Clicking on [Copy all to clipboard] should not copy that info.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: skip lines without information, patch v1

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 663344 [details] [diff] [review]
skip lines without information, patch v1

Review of attachment 663344 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/aboutSupport.js
@@ +297,5 @@
>  
>  function generateTextForElement(elem, indent, textFragmentAccumulator) {
> +  if (elem.classList.contains("no-copy")) {
> +    return;
> +  }

Looks like elsewhere in the file we don't brace single statements so drop those.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: skip lines without information, patch v2

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Thanks for the patch, Archaeopteryx! It's in my queue to land. One request - for future patches, please make sure that they contain all the needed commit information in them per the guidelines below. It makes life easier for those committing on your behalf. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be23db843f50

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/be23db843f50

Comment 7

[Chris Ilias [:cilias]]

Looks like this fix didn't include about:buildconfig, so I filed bug 871220.