Closed Bug 787289 Opened 9 years ago Closed 9 years ago

Don't copy useless info from about:support

Categories

(Toolkit :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: cilias, Assigned: aryx)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Right now, if you go to Help > Troubleshooting Information (or about:support), and click on [Copy all to clipboard], the text in the clipboard includes info that doesn't need to be copy and pasted.

These include:

        Profile Folder

          Show in Finder

        Enabled Plugins

          about:plugins

        Build Configuration

          about:buildconfig

        Crash Reports

          about:crashes

        Memory Use

          about:memory


Those are just links to other pages (and the profile folder), and don't need to be copied/pasted.

Clicking on [Copy all to clipboard] should not copy that info.
Assignee: nobody → archaeopteryx
Status: NEW → ASSIGNED
Attachment #663344 - Flags: review?(dtownsend+bugmail)
Comment on attachment 663344 [details] [diff] [review]
skip lines without information, patch v1

Review of attachment 663344 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/aboutSupport.js
@@ +297,5 @@
>  
>  function generateTextForElement(elem, indent, textFragmentAccumulator) {
> +  if (elem.classList.contains("no-copy")) {
> +    return;
> +  }

Looks like elsewhere in the file we don't brace single statements so drop those.
Attachment #663344 - Flags: review?(dtownsend+bugmail) → review+
Thanks for the patch, Archaeopteryx! It's in my queue to land. One request - for future patches, please make sure that they contain all the needed commit information in them per the guidelines below. It makes life easier for those committing on your behalf. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
https://hg.mozilla.org/mozilla-central/rev/be23db843f50
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Blocks: 871220
Looks like this fix didn't include about:buildconfig, so I filed bug 871220.
You need to log in before you can comment on or make changes to this bug.