787299 - Device Storage - Filter out mimetypes during calculation of disk usages

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Doug Turner (:dougt)]

Currently we ignore file mime type when calculating disk usage.  This means, on gaia, you can not tell how much "pictures" verses "videos" is taking up (since all types are backed by one file system).

What we should do is have DirectoryDiskUsage() take a type and filter based on that.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 658522 [details] [diff] [review]
patch v.1

Review of attachment 658522 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/devicestorage/nsDeviceStorage.cpp
@@ -151,2 @@
>  {
> -  NS_ASSERTION(NS_IsMainThread(), "Wrong thread!");

Hm, why remove this? Can the string bundle service really be used on a non-main thread?

Comment 3

[Doug Turner (:dougt)]

> Hm, why remove this?

I enumerate the file system on a non-main thread and need to call isType().  There are probably other ways to do it.

> Can the string bundle service really be used on a non-main thread?

Looks like it.  quickly scanning the implementation, it has locks in the places you'd expect.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 658522 [details] [diff] [review]
patch v.1

Review of attachment 658522 [details] [diff] [review]:
-----------------------------------------------------------------

We agreed on irc to rework this in a followup to do string bundle stuff on main thread only. r+ on this for now.

Comment 5

[Doug Turner (:dougt)]

followup bug 788612

Comment 6

[Doug Turner (:dougt)]

https://hg.mozilla.org/mozilla-central/rev/108c96a5c2c0

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Backed out for orange

https://hg.mozilla.org/mozilla-central/rev/fd4d9c386f97

Comment 8

[Doug Turner (:dougt)]

https://hg.mozilla.org/mozilla-central/rev/6996c091767d

Comment 9

[Ed Morley [:emorley]]

Push backed out for introducing new M2 orange in test_diskSpace.html & backout of the cset that landed it having conflicts. 

Also, please do not push to mozilla-central unless you are going to watch/star your push (sheriffs are going to be getting more strict about tree rule violations; ie backout).

https://hg.mozilla.org/mozilla-central/rev/5faccd0b7618

Comment 10

[Doug Turner (:dougt)]

https://hg.mozilla.org/mozilla-central/rev/089c534af34e