787380 - B2G Updates: Show a prompt to confirm or defer downloading an update

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Marshall Culpepper [:marshall_law]]

This is the initial work for a basic download prompt, more work will need to be done in follow-ups to satisfy UX requirements.

Comment 1

[Marshall Culpepper [:marshall_law]]

Attachment: updater download events - v1

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 657261 [details] [diff] [review]
updater download events - v1

Review of attachment 657261 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comments addressed.

::: b2g/components/UpdatePrompt.js
@@ +38,5 @@
>  
> +  getUpdateService: function UP_getUpdateService() {
> +    return Cc["@mozilla.org/updates/update-service;1"].
> +           getService(Ci.nsIApplicationUpdateService);
> +  },

Use a lazy service getter instead.

@@ +47,5 @@
>    // updates when on a billed pipe.  Initially, opt-in for 3g, but
>    // that doesn't cover all cases.
>    checkForUpdates: function UP_checkForUpdates() { },
> +
> +  showUpdateAvailable: function UP_showUpdateAvailable(update) {

s/update/aUpdate, and same prefixing on all other methods.

Comment 3

[Marshall Culpepper [:marshall_law]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fcba4a9eb585

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fcba4a9eb585