787410 - Allow overriding plugin hang report submission URL via prefs

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Benjamin Smedberg]

On top of bug 784145, I'm going to be running a custom server for processing plugin hang reports for a few months until Socorro grows the required features. I want to be able to redirect only plugin hang reports to this new server via pref.

Comment 1

[Benjamin Smedberg]

Attachment: URL override, Simple, I promise! rev. 1

Comment 2

[Benjamin Smedberg]

Attachment: This time it actually works, rev. 1.1

I carefully set up a variable and then didn't use it. Dumb.

Comment 3

[Benjamin Smedberg]

Comment on attachment 657362 [details] [diff] [review]
This time it actually works, rev. 1.1

This doesn't actually do the pref change, which should be in firefox.js. Per bug 784106 the pref should almost certainly be

pref("toolkit.crashreporter.pluginHangSubmitURL", "https://hang-reports.mozilla.org/submit")

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 657362 [details] [diff] [review]
This time it actually works, rev. 1.1

Review of attachment 657362 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/crashreporter/CrashSubmit.jsm
@@ +220,5 @@
> +      try {
> +        serverURL = Services.prefs.
> +          getCharPref("toolkit.crashreporter.pluginHangSubmitURL");
> +      } catch(e) { }
> +    }

The only thing you'll want to watch for here is that this doesn't break the existing unit tests. We might have to set this pref in the mochitest harness to avoid that. You can probably get away with just setting it in the tests that test plugin hangs.

Comment 5

[Georg Fritzsche [:gfritzsche]]

Pushed to try with an invalid hang submit URL to see if any tests need fixing:
https://tbpl.mozilla.org/?tree=Try&rev=bca73d85af8f

Comment 6

[Benjamin Smedberg]

Heh, I started my own earlier: https://tbpl.mozilla.org/?tree=Try&rev=031d365d7556

https://hg.mozilla.org/integration/mozilla-inbound/rev/17ed230e886a
https://hg.mozilla.org/integration/mozilla-inbound/rev/eba1d55e5c0c

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/17ed230e886a
https://hg.mozilla.org/mozilla-central/rev/eba1d55e5c0c