Closed Bug 787410 Opened 9 years ago Closed 9 years ago

Allow overriding plugin hang report submission URL via prefs

Categories

(Toolkit :: Crash Reporting, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(1 file, 1 obsolete file)

On top of bug 784145, I'm going to be running a custom server for processing plugin hang reports for a few months until Socorro grows the required features. I want to be able to redirect only plugin hang reports to this new server via pref.
Assignee: nobody → benjamin
Status: NEW → ASSIGNED
Attachment #657281 - Flags: review?(ted.mielczarek)
Attachment #657281 - Attachment is obsolete: true
Attachment #657281 - Flags: review?(ted.mielczarek)
I carefully set up a variable and then didn't use it. Dumb.
Attachment #657362 - Flags: review?(ted.mielczarek)
Comment on attachment 657362 [details] [diff] [review]
This time it actually works, rev. 1.1

This doesn't actually do the pref change, which should be in firefox.js. Per bug 784106 the pref should almost certainly be

pref("toolkit.crashreporter.pluginHangSubmitURL", "https://hang-reports.mozilla.org/submit")
Comment on attachment 657362 [details] [diff] [review]
This time it actually works, rev. 1.1

Review of attachment 657362 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/crashreporter/CrashSubmit.jsm
@@ +220,5 @@
> +      try {
> +        serverURL = Services.prefs.
> +          getCharPref("toolkit.crashreporter.pluginHangSubmitURL");
> +      } catch(e) { }
> +    }

The only thing you'll want to watch for here is that this doesn't break the existing unit tests. We might have to set this pref in the mochitest harness to avoid that. You can probably get away with just setting it in the tests that test plugin hangs.
Attachment #657362 - Flags: review?(ted.mielczarek) → review+
Pushed to try with an invalid hang submit URL to see if any tests need fixing:
https://tbpl.mozilla.org/?tree=Try&rev=bca73d85af8f
You need to log in before you can comment on or make changes to this bug.