787412 - HTMLOptionElement.prototype.text should use do a deep tree traversal

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Tobias Scheer]

Attachment: BUG.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/536.11 (KHTML, like Gecko) Chrome/20.0.1132.47 Safari/536.11

Steps to reproduce:

Apply Google Website Translator to a website and translate from German to English.


Actual results:

Select elements are displayed empty because of changing <SELECT><OPTION>TEXT</OPTION></SELECT> to <SELECT><OPTION><FONT><FONT>TEXT</FONT></FONT></OPTION></SELECT>. Other browsers removes the false FONT tags, FireFox doesn't.


Expected results:

Correct display of selected option in select-elements.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://software.hixie.ch/utilities/js/live-dom-viewer/saved/1732

Note that the HTML parser ignores the font tags when parsing "<SELECT><OPTION><FONT><FONT>TEXT</FONT></FONT></OPTION></SELECT>".

Comment 3

[Boris Zbarsky [:bzbarsky]]

The real issue here is the spec says:

  The text IDL attribute, on getting, must return the value of the textContent IDL
  attribute on the element, ...

while our impl does:

  nsContentUtils::GetNodeTextContent(this, false, text);

Note the false for aDeep.  It should perhaps be true instead?

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 5

[Mounir Lamouri (:mounir)]

Comment on attachment 657389 [details] [diff] [review]
Patch v1

Review of attachment 657389 [details] [diff] [review]:
-----------------------------------------------------------------

Could you put the new test in the forms/ subdirectory?

Also, since when did we moved to w3c-style tests?

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/79504d9c90d3