787417 - ShouldPrerender() check should be based on area, not dimensions

Status: NEW

(Core :: Layout, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

The check boils down to

  if (frameSize <= refSize) {

but that's kind of broken: I think I intended for this to be a check of area, but the <= operator does

  width <= aSize.width && height <= aSize.height;

Which means that a 1 x screen.height + \epsilon frame, e.g., wouldn't be prerendered.  That's silly.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Vivien: I think Ian may have worked around this bug in the radio app.  If so, please tell him I'm sorry and we're fixing this! :)

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Small issue with nice perf win that's come up in important content, like the FM radio app.

Comment 3

[David Zbarsky (:dzbarsky)]

We should just change this to account for scaling.