Closed
Bug 787443
Opened 14 years ago
Closed 14 years ago
CmdCmd.jsm and CmdCookie.jsm include Console.jsm with the wrong url
Categories
(DevTools :: General, defect)
Tracking
(firefox17 fixed)
RESOLVED
FIXED
Firefox 18
| Tracking | Status | |
|---|---|---|
| firefox17 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
2.25 KB,
patch
|
jwalker
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
It's resource://gre/modules/devtools/Console.jsm, not resource:///modules/devtools/Console.jsm
| Assignee | ||
Updated•14 years ago
|
status-firefox17:
--- → affected
| Assignee | ||
Comment 1•14 years ago
|
||
Comment 2•14 years ago
|
||
Comment on attachment 657303 [details] [diff] [review]
CmdCmd.jsm and CmdCookie.jsm include Console.jsm with the wrong url
Review of attachment 657303 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks. I'll add this to my list of things to land.
Attachment #657303 -
Flags: review+
| Assignee | ||
Comment 3•14 years ago
|
||
(In reply to Joe Walker [:jwalker] from comment #2)
> Thanks. I'll add this to my list of things to land.
That's okay, i'll land it with other things i need to land.
| Assignee | ||
Comment 4•14 years ago
|
||
| Assignee | ||
Comment 5•14 years ago
|
||
Comment on attachment 657303 [details] [diff] [review]
CmdCmd.jsm and CmdCookie.jsm include Console.jsm with the wrong url
[Approval Request Comment]
User impact if declined: This breaks Firefox when built as a xulrunner application
Risk to taking this patch (and alternatives if risky): Low. On mozilla builds, we're effectively changing an url to another url that resolves to the exact same location.
String or UUID changes made by this patch: None
Attachment #657303 -
Flags: approval-mozilla-aurora?
Comment 6•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Updated•14 years ago
|
Attachment #657303 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
| Assignee | ||
Comment 7•14 years ago
|
||
Comment 8•14 years ago
|
||
Is there a reason for the qa-?
qa- simply means this bug is not a first priority for verification by QA. We don't have time nor resources to verify all bugs so we have to prioritize. Apologies for not clarifying earlier.
If you think this bug is critical to be verified before we ship Firefox 17 please make a justification.
Thanks.
Updated•8 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•