787512 - Pack bits in nsListenerStruct better on Windows

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

The boolean we added in Bug 687332 pushes the struct size from 16 to 17 bytes, which jemalloc rounds up to 32.  There's no reason the booleans can't fit inside 16 bytes, so we're using double the memory we should for this struct.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 657383 [details] [diff] [review]
Patch

Review of attachment 657383 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/nsEventListenerManager.h
@@ +40,5 @@
>  struct nsListenerStruct
>  {
>    nsRefPtr<nsIDOMEventListener> mListener;
>    uint32_t                      mEventType;
>    nsCOMPtr<nsIAtom>             mTypeAtom;

Would swapping around those two save some on 64-bit too?

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Probably, but that's not what this bug is about.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 657383 [details] [diff] [review]
Patch

r=me if you made sure this actually makes Windows to pack this stuff in
a sane way.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yes, I did.  I do meet basic standards of competency. :-P

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/059f341beaad