Closed Bug 787523 Opened 7 years ago Closed 7 years ago

jsapi.cpp:1085:20: warning: converting ‘false’ to pointer type ‘JSRuntime*’ [-Wconversion-null]

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

js/src/jsapi.cpp:1085:20: warning: converting ‘false’ to pointer type ‘JSRuntime*’ [-Wconversion-null]

1051 JS_PUBLIC_API(JSRuntime *)
1052 JS_NewRuntime(uint32_t maxbytes)
1053 {
[...]
1084         if (!JS::TlsRuntime.init())
1085             return false;
https://mxr.mozilla.org/mozilla-central/source/js/src/jsapi.cpp#1085

Looks like that wants to be "return NULL;"
Attached patch fixSplinter Review
Assignee: general → dholbert
Status: NEW → ASSIGNED
Attachment #657388 - Flags: review?(terrence)
Comment on attachment 657388 [details] [diff] [review]
fix

Review of attachment 657388 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like beat you to it by a few minutes.

https://hg.mozilla.org/integration/mozilla-inbound/rev/82e8e2679938
Attachment #657388 - Flags: review?(terrence) → review+
Ah, nice. Resolving WFM.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.