787543 - Reinstate the typedef bits in the WebGLRenderingContext binding

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Once bug 742144 lands.  Also, once bug 778150 lands, because otherwise there will be unhappiness and bitrot everywhere, with crows circling above the smoke.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch, not the best thing to review

Easier to review diff coming up

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Diff from the spec IDL to our in-tree IDL. Might want to just review this.

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 659446 [details] [diff] [review]
Patch, not the best thing to review

Review of attachment 659446 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/WebGLRenderingContext.webidl
@@ +39,5 @@
> +typedef octet          GLubyte;        /* 'octet' should be an unsigned 8 bit type. */
> +typedef unsigned short GLushort;
> +typedef unsigned long  GLuint;
> +typedef float          GLfloat;
> +typedef float          GLclampf;  

Trailing whitespace, but I guess we're copying that from the spec :-(.

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/034e75e31d2e

Comment 5

[(Out Sep 17-23) Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/034e75e31d2e