787545 - When creating a new session on Fennec the socket times out

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

When I try get a new session from Marionette something happens and causes a socket.timeout


>>> m = Marionette('localhost', 2826)
>>> m.start_session()                                                          
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/davidburns/mozilla-inbound/testing/marionette/client/marionette/m
arionette.py", line 239, in start_session
    self.session = self._send_message('newSession', 'value')
  File "/home/davidburns/mozilla-inbound/testing/marionette/client/marionette/m
arionette.py", line 152, in _send_message
    response = self.client.send(message)
  File "/home/davidburns/mozilla-inbound/testing/marionette/client/marionette/c
lient.py", line 84, in send
    response = self.receive()
  File "/home/davidburns/mozilla-inbound/testing/marionette/client/marionette/c
lient.py", line 52, in receive
    raise MarionetteException("Could not successfully complete transport of mes
sage to Gecko, socket closed?")
marionette.errors.MarionetteException: Could not successfully complete transpor
t of message to Gecko, socket closed?
>>>

Comment 1

[Jonathan Griffin (:jgriffin)]

This isn't too surprising.  When you create a new session, Marionette tries to attach itself to the browser window.  To do this, it needs to know something about how that's implemented, which varies between Firefox, Fennec and B2G.  We have code to handle the Firefox and B2G cases, but not the Fennec case, so we'll have to add code to address this.

Comment 2

[David Burns :automatedtester]

I can telnet to the device and http://mxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-actors.js#74 answers so am currently connecting to Marionette.

Comment 3

[Jonathan Griffin (:jgriffin)]

The code that's dying is here: http://mxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-actors.js#1568

getBrowserForTab and related functions don't exist in Fennec, they're Firefox specific.  We need to figure out the Fennec analogs, probably from http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js, and use them in the Fennec case.

Comment 4

[David Burns :automatedtester]

Thanks :jgriffin, I suspect there are going to be a number of similar things like this as I get marionette working on Fennec.

Comment 5

[David Burns :automatedtester]

Attachment: Allow marionette to work on Fennec

Comment 6

[Jonathan Griffin (:jgriffin)]

Comment on attachment 661875 [details] [diff] [review]
Allow marionette to work on Fennec

Review of attachment 661875 [details] [diff] [review]:
-----------------------------------------------------------------

This looks ok to me.  I assume you've verified it doesn't break with Firefox?  This doesn't create a new tab on Fennec for a new session, as we do for Firefox.  I'm assuming that's acceptable; we can always change that behavior later if needed.

Comment 7

[David Burns :automatedtester]

(In reply to Jonathan Griffin (:jgriffin) from comment #6)
> Comment on attachment 661875 [details] [diff] [review]
> Allow marionette to work on Fennec
> 
> Review of attachment 661875 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This looks ok to me.  I assume you've verified it doesn't break with
> Firefox?  

Most definitely! Not wanting mud on my face!

>This doesn't create a new tab on Fennec for a new session, as we
> do for Firefox.  I'm assuming that's acceptable; we can always change that
> behavior later if needed.

Since the primary use case, that I know of, is running against web apps in the web runtime, I don't know how well the tabs are going to work but as you say, if I need to change it it should be simple :)

Thanks for the r+

Comment 8

[David Burns :automatedtester]

landed in http://hg.mozilla.org/integration/mozilla-inbound/rev/eacd4f900b56

Comment 9

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/eacd4f900b56