787552 - B2G Wifi: Add APIs to get the MAC address and current IP address

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Kaze asked the other day for APIs to get the MAC address and the current IP address if we're connected. We'll need:

interface nsIDOMWifiManager {
   readonly attribute DOMString macAddress;
};

interface nsIDOMMozWifiConnectionInfoEvent {
   readonly attribute DOMString ipAddress;
};

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

I think Kaze told me that these were P2s for him.

Comment 2

[Fabien Cazenave [:kaze]]

I confirm I could live without knowing the MAC address of my device. Nice to have, though.

Comment 3

[Andrew Overholt [:overholt]]

Based on comments 1 and 2, not blocking Basecamp.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

This seems to do the trick.

Comment 5

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 662710 [details] [diff] [review]
Proposed fix

Review of attachment 662710 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/wifi/WifiWorker.js
@@ +1501,4 @@
>      WifiManager.enabled = true;
>      self._updateWifiSetting(true);
>      WifiManager.getMacAddress(function (mac) {
> +      self.macAddress = mac;

Do we need the mac address information when wifi is disabled during device start-up ? 
Android also doesn't show mac address in this case ?

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

(In reply to Vincent Chang from comment #5)
> Do we need the mac address information when wifi is disabled during device
> start-up ? 
> Android also doesn't show mac address in this case ?

Good questions! Android shows the MAC address as "not available" until wifi is turned on (and then it remembers it afterwards). So, I think the current behavior should be OK.

Comment 7

[Fabien Cazenave [:kaze]]

The front-end is ready… and waiting: https://github.com/mozilla-b2g/gaia/pull/5267

Asking for check-in.

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 662710 [details] [diff] [review]
Proposed fix

(inferring the f+ from kaze's comment)

https://hg.mozilla.org/integration/mozilla-inbound/rev/c4f422d91514

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c4f422d91514