787588 - IPC is still broken on DragonFly

Status: RESOLVED FIXED

(Core :: IPC, defect)

Comment 1

[Jan Beich]

Attachment: Bug 787588 - d_reclen is dead on DragonFly since 64bit inode support.

Not enough testing of bug 753046 bites me now.

ipc/chromium/src/base/dir_reader_bsd.h:52:26: error: no member named
      'd_reclen' in 'dirent'
      offset_ += dirent->d_reclen;
                 ~~~~~~  ^

ino64 on different BSDs:
  http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/01f31ab
  https://github.com/jsonn/src/commit/7fc2e39 # netbsd
  https://github.com/glk/freebsd-ino64/commit/4dd4b16 # not landed yet

Comment 2

[Jan Beich]

Comment on attachment 657477 [details] [diff] [review]
Bug 787588 - d_reclen is dead on DragonFly since 64bit inode support.

The file is not used on non-BSDs. Trying Landry.

Original PR is now closed after the following fix.
http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/devel/xulrunner/patches/patch-ipc_chromium_src_base_dir__reader__bsd.h.diff?r1=1.2&r2=1.3

Comment 3

[Landry Breuil (:gaston)]

Comment on attachment 657477 [details] [diff] [review]
Bug 787588 - d_reclen is dead on DragonFly since 64bit inode support.

If it builds for you...

Comment 4

[Landry Breuil (:gaston)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/186b0a9bd97b

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/186b0a9bd97b