Closed Bug 787687 Opened 12 years ago Closed 12 years ago

SQLite doesn't support CHAR_LENGTH natively

Categories

(Bugzilla :: Installation & Upgrading, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 4.4

People

(Reporter: wicked, Assigned: LpSolit)

References

Details

Attachments

(1 file)

Ever since bug 187753 went in 18th Aug, landfill cron update of bugzilla-sqlite-tip has been yelling about: DBD::SQLite::db selectall_arrayref failed: no such function: CHAR_LENGTH [for Statement "SELECT quipid, quip FROM quips WHERE CHAR_LENGTH(quip) > 512"] at Bugzilla/Install/DB.pm line 3759 Bugzilla::Install::DB::_shorten_long_quips() called at Bugzilla/Install/DB.pm line 701 Bugzilla::Install::DB::update_table_definitions('HASH(0x89fbe68)') called at ./checksetup.pl line 169 And true enough, running checksetup.pl fails with this same error.
Attached patch patch, v1Splinter Review
Assignee: installation → LpSolit
Status: NEW → ASSIGNED
Attachment #657576 - Flags: review?(wicked)
Flags: blocking4.4+
Summary: SQLite checksetup broken due to using an unsupported CHAR_LENGTH DB function → SQLite doesn't support CHAR_LENGTH natively
Target Milestone: --- → Bugzilla 4.4
Comment on attachment 657576 [details] [diff] [review] patch, v1 Yay! Shortening quips longer than 512 characters: 488 489 616 Updating column quip in table quips ... Old: text NOT NULL COLLATE bugzilla New: varchar(512) NOT NULL COLLATE bugzilla checksetup.pl complete.
Attachment #657576 - Flags: review?(wicked) → review+
Flags: approval?
Flags: approval4.4?
Flags: approval?
Flags: approval4.4?
Flags: approval4.4+
Flags: approval+
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified Bugzilla/DB/Sqlite.pm Committed revision 8381. Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/ modified Bugzilla/DB/Sqlite.pm Committed revision 8379.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: