Consider disabling tab animations when they're too slow

RESOLVED WONTFIX

Status

()

Firefox
Tabbed Browser
RESOLVED WONTFIX
5 years ago
a year ago

People

(Reporter: marco, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Snappy:p2])

(Reporter)

Description

5 years ago
We have a lot of performance problems related to tab animations.
Is disabling tab animations until we fix them a viable option?

(Currently with animations enabled, if you enable nglayout.debug.paint_flashing, you can see a lot of repaints of the entire chrome when you open or close a tab, without animations there's only a single repaint)

Comment 1

5 years ago
This might be on ok nuclear option on slower hardware
Whiteboard: [Snappy]
(Reporter)

Comment 2

5 years ago
Would it be feasible to disable tab animations -after- we have done some measurements and proved they are too slow?
(Reporter)

Comment 3

5 years ago
(In reply to Marco Castelluccio [:marco] from comment #2)
> Would it be feasible to disable tab animations -after- we have done some
> measurements and proved they are too slow?

We could set a threshold (like 200-300 ms) and, when a certain number of FX_TAB_* telemetry measures are higher than the threshold, disable the animations.

Comment 4

5 years ago
lets p2 this while we try to make tab animations better in bug 815354
Whiteboard: [Snappy] → [Snappy:p2]
(Reporter)

Updated

4 years ago
Summary: Consider disabling tab animations → Consider disabling tab animations when they're too slow

Comment 5

4 years ago
(In reply to Marco Castelluccio [:marco] from comment #3)
> (In reply to Marco Castelluccio [:marco] from comment #2)
> > Would it be feasible to disable tab animations -after- we have done some
> > measurements and proved they are too slow?
> 
> We could set a threshold (like 200-300 ms) and, when a certain number of
> FX_TAB_* telemetry measures are higher than the threshold, disable the
> animations.

- Tab open/close times are less indicative than animation smoothness (frames per second). Bug 828097 would add telemetry for that.

- Telemetry is not enabled by default, so using telemetry FX_TAB_* would not work for some (most?) users.

- AFAIK, Enabling telemetry is only offered once - after the first REstart of the browser. Having one browsing session with animation enabled, then possibly disabling animation sometime during the 2nd browsing session might create a confusing/inconsistent behavior.

I suggest to instrument the first* N (1? 3?) tab animations (using the system of bug 826383), and decide upon that.

* We should choose if first means only for new users, or also for existing profiles, where "first" would mean "first time after the auto-disable system is in place".
(Reporter)

Comment 6

a year ago
I guess this isn't going to happen.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.