Closed Bug 787745 Opened 12 years ago Closed 12 years ago

Intermittent browser_DeferredTask.js | Deferred task 3 shouldn't be pending - Got true, expected false & Deferred task 1 should be pending - Got false, expected true

Categories

(Toolkit :: General, defect)

Product:
Toolkit
Component:
General
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla18

People

(Reporter: RyanVM, Assigned: andreshm)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Patch v1
1.20 KB, patch
Gavin
: review+
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=14891229&tree=Mozilla-Inbound Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound opt test mochitest-other on 2012-08-31 16:58:12 PDT for push a412d39f5526 slave: talos-r4-snow-035 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/content/tests/browser/browser_DeferredTask.js | Deferred task 3 shouldn't be pending - Got true, expected false Stack trace: JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 471 JS frame :: chrome://mochitests/content/browser/toolkit/content/tests/browser/browser_DeferredTask.js :: <TOP_LEVEL> :: line 130 JS frame :: resource:///modules/DeferredTask.jsm :: onCallback :: line 30 TEST-INFO | chrome://mochitests/content/browser/toolkit/content/tests/browser/browser_DeferredTask.js | Starting testRestartItselfTask TEST-INFO | chrome://mochitests/content/browser/toolkit/content/tests/browser/browser_DeferredTask.js | Deferred task 3 running TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/content/tests/browser/browser_DeferredTask.js | Deferred task 1 should be pending - Got false, expected true Stack trace: JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 471 JS frame :: chrome://mochitests/content/browser/toolkit/content/tests/browser/browser_DeferredTask.js :: <TOP_LEVEL> :: line 140 JS frame :: resource:///modules/DeferredTask.jsm :: onCallback :: line 30
Assignee: nobody → andres
Attached patch Patch v1 — — Splinter Review
The failing test is 'testRestartingTask', where one task is restarted in another task. When a test is running and it is restarted, then the delay of the timer is updated. I suspect this is the problem, so, I change it to cancel the timer and start it again. I pushed it to try: https://tbpl.mozilla.org/?tree=Try&rev=05c91752eb8a
Try finished green. Just one unrelated orange. https://tbpl.mozilla.org/?tree=Try&rev=05c91752eb8a
Attachment #659044 - Flags: review?(ryanvm)
Comment on attachment 659044 [details] [diff] [review] Patch v1 I'm not a peer for this code. Maybe Gavin can review it.
Attachment #659044 - Flags: review?(ryanvm) → review?(gavin.sharp)
Comment on attachment 659044 [details] [diff] [review] Patch v1 Worth a shot!
Attachment #659044 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/mozilla-central/rev/31d9c13dcd27
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: