Last Comment Bug 787802 - Port |Bug 762230 - Add-ons not listed when resetting Sync|
: Port |Bug 762230 - Add-ons not listed when resetting Sync|
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Sync UI (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.15
Assigned To: Jens Hatlak (:InvisibleSmiley)
:
Mentors:
Depends on: 713087
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-02 08:15 PDT by Jens Hatlak (:InvisibleSmiley)
Modified: 2012-09-03 09:22 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch [Checkin: Comment 5] (3.92 KB, patch)
2012-09-02 08:15 PDT, Jens Hatlak (:InvisibleSmiley)
neil: review+
Details | Diff | Splinter Review

Description Jens Hatlak (:InvisibleSmiley) 2012-09-02 08:15:25 PDT
Created attachment 657678 [details] [diff] [review]
patch [Checkin: Comment 5]

From the base bug:
"When you go to reset Sync and replace all your data, the UI gives a list of things that will be deleted. It doesn't show add-ons because we forgot to implement it when add-on sync landed."

Note: Porting bug 787306 will be done together with bug 785225 after they land.
Comment 1 neil@parkwaycc.co.uk 2012-09-02 09:44:29 PDT
Comment on attachment 657678 [details] [diff] [review]
patch [Checkin: Comment 5]

>+            if (i)
[I wonder what this does...]
Comment 2 Philip Chee 2012-09-02 11:46:33 PDT
> [I wonder what this does...]

> +          for each (let i in ids) {
> +            if (i)
According to jcranmer for each is an e4xism and is deprecated.
Comment 3 Jens Hatlak (:InvisibleSmiley) 2012-09-02 14:05:48 PDT
(In reply to Philip Chee from comment #2)
> According to jcranmer for each is an e4xism and is deprecated.

I'm not up-to-date there. If you tell me what to do instead I'll include it upon pushing, otherwise it'll have to go into a follow-up.
Comment 4 Philip Chee 2012-09-03 02:10:50 PDT
> I'm not up-to-date there. If you tell me what to do instead I'll include it upon
> pushing, otherwise it'll have to go into a follow-up.
Not important. Let's see how the places team fixes that then we can copy it.
Comment 5 Jens Hatlak (:InvisibleSmiley) 2012-09-03 09:21:33 PDT
Comment on attachment 657678 [details] [diff] [review]
patch [Checkin: Comment 5]

http://hg.mozilla.org/comm-central/rev/42d9d1e6f548

Note You need to log in before you can comment on or make changes to this bug.