Closed
Bug 787802
Opened 12 years ago
Closed 12 years ago
Port |Bug 762230 - Add-ons not listed when resetting Sync|
Categories
(SeaMonkey :: Sync UI, defect)
SeaMonkey
Sync UI
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.15
People
(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)
References
Details
Attachments
(1 file)
3.92 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
From the base bug:
"When you go to reset Sync and replace all your data, the UI gives a list of things that will be deleted. It doesn't show add-ons because we forgot to implement it when add-on sync landed."
Note: Porting bug 787306 will be done together with bug 785225 after they land.
Attachment #657678 -
Flags: review?(neil)
Comment 1•12 years ago
|
||
Comment on attachment 657678 [details] [diff] [review]
patch [Checkin: Comment 5]
>+ if (i)
[I wonder what this does...]
Attachment #657678 -
Flags: review?(neil) → review+
Comment 2•12 years ago
|
||
> [I wonder what this does...]
> + for each (let i in ids) {
> + if (i)
According to jcranmer for each is an e4xism and is deprecated.
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to Philip Chee from comment #2)
> According to jcranmer for each is an e4xism and is deprecated.
I'm not up-to-date there. If you tell me what to do instead I'll include it upon pushing, otherwise it'll have to go into a follow-up.
Comment 4•12 years ago
|
||
> I'm not up-to-date there. If you tell me what to do instead I'll include it upon
> pushing, otherwise it'll have to go into a follow-up.
Not important. Let's see how the places team fixes that then we can copy it.
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 657678 [details] [diff] [review]
patch [Checkin: Comment 5]
http://hg.mozilla.org/comm-central/rev/42d9d1e6f548
Attachment #657678 -
Attachment description: patch → patch [Checkin: Comment 5]
Assignee | ||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.15
You need to log in
before you can comment on or make changes to this bug.
Description
•