787808 - Metro filepicker doesn't populate filename

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Jim Mathies [:jimm]]

STR:

- press-hold on an image
- select "save image to" on the context menu

In the file picker, the filename entry is blank.

Comment 1

[Jim Mathies [:jimm]]

Also, jpg files are saved as jpe files for some reason. I couldn't test png due to bug 787809.

Comment 2

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1 - nsFilePicker shared WinRT and Win32 code

This first patch I want to land on m-c.  The second patch doesn't need a review and will land only on elm.

Comment 3

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1 - WinRT default filename code

Comment 4

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/projects/elm/rev/d3082c8f17dc
http://hg.mozilla.org/projects/elm/rev/4f1dfa05e362

Comment 5

[Brian R. Bondy [:bbondy]]

As for the default file extension.  I set that now, and I verified it gets set to .png for a .png file, but it's still using the first item in the filter list. 

The documentation says it will use the first item in the filter list if the default file extension is not set, but I'm setting it.  So I'm pretty sure this is a bug in WinRT.  I'll send an email along with the tile exists check to Microsoft.

Comment 6

[Brian R. Bondy [:bbondy]]

The is tile pinned thing works now by the way, and I don't think there were any code changes. So I guess MS fixed that one.  

I tested the default file extension problem in Metro Chrome and Metro IE as well.  But Chrome only has the 1 image type that you are saving in the drop down.  And IE doesn't give you the option to use a save file picker, it just gives a context menu item to save to picture library.

Comment 7

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/9d6fb0b4c21e

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9d6fb0b4c21e