Closed Bug 787833 Opened 11 years ago Closed 11 years ago

Plugin Blocked notification fails to show

Categories

(SeaMonkey :: Security, defect, P1)

Product:
SeaMonkey
Component:
Security
Type:
defect

Tracking

(seamonkey2.12+ fixed, seamonkey2.13+ fixed, seamonkey2.14+ fixed, seamonkey2.15 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.15
Tracking Flags:
Tracking Status
seamonkey2.12 + fixed
seamonkey2.13 + fixed
seamonkey2.14 + fixed
seamonkey2.15 --- fixed

People

(Reporter: Callek, Assigned: neil)

Details

Attachments

(1 file)

Proposed patch
1.11 KB, patch
iannbugzilla
: review+
Callek
: approval-comm-aurora+
Callek
: approval-comm-beta+
Callek
: approval-comm-release+
Details | Diff | Splinter Review 
Unfortunately our Plugin Block Notification fails to show [e.g. when testing old Java versions with new blocklist] 

I'm in favor of a chemspill for this issue.
Attached patch Proposed patch — — Splinter Review 
I couldn't find any other places where we don't flush layout on the plugin.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #657711 - Flags: review?(iann_bugzilla)
(In reply to Justin Wood (:Callek) from comment #0)
> I'm in favor of a chemspill for this issue.

Callek, you said TB might also have to do a minor release, for different reasons. Let's not do two minor releases in quick succession but just one, if we can. [Further discussion can go to the mailing lists or newsgroups.]
(In reply to Jens Hatlak (:InvisibleSmiley) from comment #2)
> (In reply to Justin Wood (:Callek) from comment #0)
> > I'm in favor of a chemspill for this issue.
> 
> Callek, you said TB might also have to do a minor release, for different
> reasons. Let's not do two minor releases in quick succession but just one,
> if we can. [Further discussion can go to the mailing lists or newsgroups.]

Agreed, I do plan to investigate likelihood of TB doing a chemspill-style release before I push this out.
Attachment #657711 - Flags: review?(iann_bugzilla) → review+
Pushed comm-central changeset 1915fa3c4e73.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 657711 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
User impact if declined: Important plugin notifications may not appear
Risk to taking this patch: Very low
String changes made by this patch: None
Attachment #657711 - Flags: approval-comm-beta?
Attachment #657711 - Flags: approval-comm-aurora?
Comment on attachment 657711 [details] [diff] [review]
Proposed patch

Please land on comm-release as well.
Attachment #657711 - Flags: approval-comm-release+
Attachment #657711 - Flags: approval-comm-beta?
Attachment #657711 - Flags: approval-comm-beta+
Attachment #657711 - Flags: approval-comm-aurora?
Attachment #657711 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.