The default bug view has changed. See this FAQ.

Plugin Blocked notification fails to show

RESOLVED FIXED in seamonkey2.15

Status

SeaMonkey
Security
P1
blocker
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Callek, Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
seamonkey2.15

SeaMonkey Tracking Flags

(seamonkey2.12+ fixed, seamonkey2.13+ fixed, seamonkey2.14+ fixed, seamonkey2.15 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Unfortunately our Plugin Block Notification fails to show [e.g. when testing old Java versions with new blocklist] 

I'm in favor of a chemspill for this issue.
(Assignee)

Comment 1

5 years ago
Created attachment 657711 [details] [diff] [review]
Proposed patch

I couldn't find any other places where we don't flush layout on the plugin.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #657711 - Flags: review?(iann_bugzilla)
(In reply to Justin Wood (:Callek) from comment #0)
> I'm in favor of a chemspill for this issue.

Callek, you said TB might also have to do a minor release, for different reasons. Let's not do two minor releases in quick succession but just one, if we can. [Further discussion can go to the mailing lists or newsgroups.]
(Reporter)

Comment 3

5 years ago
(In reply to Jens Hatlak (:InvisibleSmiley) from comment #2)
> (In reply to Justin Wood (:Callek) from comment #0)
> > I'm in favor of a chemspill for this issue.
> 
> Callek, you said TB might also have to do a minor release, for different
> reasons. Let's not do two minor releases in quick succession but just one,
> if we can. [Further discussion can go to the mailing lists or newsgroups.]

Agreed, I do plan to investigate likelihood of TB doing a chemspill-style release before I push this out.

Updated

5 years ago
Attachment #657711 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 4

5 years ago
Pushed comm-central changeset 1915fa3c4e73.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

5 years ago
Comment on attachment 657711 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
User impact if declined: Important plugin notifications may not appear
Risk to taking this patch: Very low
String changes made by this patch: None
Attachment #657711 - Flags: approval-comm-beta?
Attachment #657711 - Flags: approval-comm-aurora?
(Reporter)

Comment 6

5 years ago
Comment on attachment 657711 [details] [diff] [review]
Proposed patch

Please land on comm-release as well.
Attachment #657711 - Flags: approval-comm-release+
Attachment #657711 - Flags: approval-comm-beta?
Attachment #657711 - Flags: approval-comm-beta+
Attachment #657711 - Flags: approval-comm-aurora?
Attachment #657711 - Flags: approval-comm-aurora+

Comment 7

5 years ago
Pushed:
http://hg.mozilla.org/releases/comm-aurora/rev/86fae753e3d5
http://hg.mozilla.org/releases/comm-beta/rev/ab148243c3bc
status-seamonkey2.13: --- → fixed
status-seamonkey2.14: --- → fixed
Target Milestone: seamonkey2.12 → seamonkey2.15

Comment 8

5 years ago
Pushed to comm-release
http://hg.mozilla.org/releases/comm-release/rev/edd78fb4d7a9
status-seamonkey2.12: --- → fixed
status-seamonkey2.15: --- → fixed
You need to log in before you can comment on or make changes to this bug.