Last Comment Bug 787833 - Plugin Blocked notification fails to show
: Plugin Blocked notification fails to show
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Security (show other bugs)
: Trunk
: All All
: P1 blocker (vote)
: seamonkey2.15
Assigned To: neil@parkwaycc.co.uk
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-02 13:55 PDT by Justin Wood (:Callek)
Modified: 2012-09-03 08:05 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
+
fixed
+
fixed
+
fixed
fixed


Attachments
Proposed patch (1.11 KB, patch)
2012-09-02 13:58 PDT, neil@parkwaycc.co.uk
iann_bugzilla: review+
bugspam.Callek: approval‑comm‑aurora+
bugspam.Callek: approval‑comm‑beta+
bugspam.Callek: approval‑comm‑release+
Details | Diff | Splinter Review

Description Justin Wood (:Callek) 2012-09-02 13:55:44 PDT
Unfortunately our Plugin Block Notification fails to show [e.g. when testing old Java versions with new blocklist] 

I'm in favor of a chemspill for this issue.
Comment 1 neil@parkwaycc.co.uk 2012-09-02 13:58:36 PDT
Created attachment 657711 [details] [diff] [review]
Proposed patch

I couldn't find any other places where we don't flush layout on the plugin.
Comment 2 Jens Hatlak (:InvisibleSmiley) 2012-09-02 14:03:36 PDT
(In reply to Justin Wood (:Callek) from comment #0)
> I'm in favor of a chemspill for this issue.

Callek, you said TB might also have to do a minor release, for different reasons. Let's not do two minor releases in quick succession but just one, if we can. [Further discussion can go to the mailing lists or newsgroups.]
Comment 3 Justin Wood (:Callek) 2012-09-02 14:10:47 PDT
(In reply to Jens Hatlak (:InvisibleSmiley) from comment #2)
> (In reply to Justin Wood (:Callek) from comment #0)
> > I'm in favor of a chemspill for this issue.
> 
> Callek, you said TB might also have to do a minor release, for different
> reasons. Let's not do two minor releases in quick succession but just one,
> if we can. [Further discussion can go to the mailing lists or newsgroups.]

Agreed, I do plan to investigate likelihood of TB doing a chemspill-style release before I push this out.
Comment 4 neil@parkwaycc.co.uk 2012-09-02 15:43:34 PDT
Pushed comm-central changeset 1915fa3c4e73.
Comment 5 neil@parkwaycc.co.uk 2012-09-02 15:45:08 PDT
Comment on attachment 657711 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
User impact if declined: Important plugin notifications may not appear
Risk to taking this patch: Very low
String changes made by this patch: None
Comment 6 Justin Wood (:Callek) 2012-09-02 15:58:56 PDT
Comment on attachment 657711 [details] [diff] [review]
Proposed patch

Please land on comm-release as well.
Comment 8 Philip Chee 2012-09-03 08:05:55 PDT
Pushed to comm-release
http://hg.mozilla.org/releases/comm-release/rev/edd78fb4d7a9

Note You need to log in before you can comment on or make changes to this bug.