787866 - Remove SharedContext::fun_

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

SharedContext::fun_ can be removed;  it's subsumed by SharedContext::funbox_
(except when it's not, but I'll fix that case).

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Remove unused |cx| parameter from ContextFlags().

Part 1.  This patch removes the unused |cx| parameter from ContextFlags().

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Don't call function-only methods on non-function SharedContexts.

There are various function-specific flags in SharedContext::cxFlags.  For 
some of them, we assert that we're in a function context when we get/set 
them.  But for others we don't.  This patch tightens things up so that we 
assert for all of them.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Remove SharedContext::fun_.

Function-specific SharedContexts have a |fun_| and a |funbox_| field, even 
though FunctionBox is just a glorified wrapper of a JSFunction.  This seems
to be because CompileFunctionBody() doesn't provide a FunctionBox.

This patch changes it so that CompileFunctionBody() does provide a 
FunctionBox, which allows us to remove SharedContext::fun_.  One minor 
consequence is that we have to handle a NULL |outerpc| in newFunctionBox()
and FunctionBox().

AIUI the GC rooting will be ok because FunctionBox is heap-allocated and
traced by Parser::trace().

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d22b3ddf593
https://hg.mozilla.org/integration/mozilla-inbound/rev/55639ec64ed2
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ea27df2919a

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2d22b3ddf593
https://hg.mozilla.org/mozilla-central/rev/55639ec64ed2
https://hg.mozilla.org/mozilla-central/rev/3ea27df2919a