787877 - History list is not updated when removing the last entry using the context menu

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Adrian Tamas (:AdrianT)]

Attachment: logs

Nightly 18.0a1 2012-09-02/ Aurora 17.0a2 2012-09-02/ Firefox Mobile 16.0b1 
Samsung Galaxy Tab 2 7.0 (Android 4.0.4)/ Samsung Galaxy R (Android 2.3.4)

Steps to reproduce:
1. Make sure you have entrees in the History section.
2. Tap the URL bar to access the History tab.
3. Long tap on one entree for the context menu to appear.
4. Repeat step 4 and remove all entrees using the remove button.

Expected:
A toast notification appears whit the message "Page Removed" and all entrees from the History section are removed. 

Actual:
If there is only one item in the history section the toast notification appears but the item is still present. Only after going back and accessing another time the awesome-menu the History tab is updated and the entree is removed.

Note:
The issue was resolved in bug 759120 and is not reproducible on Firefox Mobile 15 release. This is a regression.

Comment 1

[Aaron Train [:aaronmt]]

Let's find a window.

Comment 2

[Adrian Tamas (:AdrianT)]

A new test case has been created in the BFTs run in the History suite:

https://moztrap.mozilla.org/manage/cases/_detail/6331/

Comment 3

[Adrian Tamas (:AdrianT)]

Good build: 2012-06-30
Bad build: 2012-07-01

Push log: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f08d285b63b0&tochange=d9d61d199b11

Comment 4

[Aaron Train [:aaronmt]]

Looks like bug 759041.

Comment 5

[Lucas Rocha (:lucasr)]

Attachment: Re-apply patch from bug 759120 on new awesomebar tab code

Comment 6

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/b94134ca469a

Comment 7

[Lucas Rocha (:lucasr)]

Comment on attachment 659182 [details] [diff] [review]
Re-apply patch from bug 759120 on new awesomebar tab code

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 759041 refactoring a large part of the awesomescreen code and somehow reverted a patch in the process.
User impact if declined: History list in awesomescreen is not updated when user removes the last item.
Testing completed (on m-c, etc.): Existing patch (from bug 759120) re-applied in new code. We now it works.
Risk to taking this patch (and alternatives if risky): Low, known issue with proven patch.
String or UUID changes made by this patch: None.

Comment 8

[Alex Keybl [:akeybl]]

Once this has had a little time to bake on Nightly, we'll approve for Aurora/Beta.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b94134ca469a

Comment 10

[Cristian Nicolae (:xti)]

The last entry is removed as expected from History Tab. Closing bug as verified fixed on:

Firefox 18.0a1 (2012-09-13)
Device: Galaxy Note
OS: Android 4.0.4

Comment 11

[Lucas Rocha (:lucasr)]

Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/69f70ee98823

Pushed to beta:
https://hg.mozilla.org/releases/mozilla-beta/rev/b64b5f61109f

Comment 12

[Cristian Nicolae (:xti)]

This issue is not reproducible anymore on the latest Aurora and Nightly build.

--
Device: Galaxy Note
OS: Android 4.0.4