Closed
Bug 787906
Opened 12 years ago
Closed 12 years ago
IonMonkey: Don't generate a shift instruction for x >>> 0
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
12.46 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
I missed this before because no asm spew was printed for the shrl instructions. The patch fixes this and avoids generating a shift instruction if the shift amount is 0. I had to restructure the code a bit, but the patch is pretty straight-forward.
Attachment #657817 -
Flags: review?(dvander)
Updated•12 years ago
|
Attachment #657817 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 1•12 years ago
|
||
https://hg.mozilla.org/projects/ionmonkey/rev/93bb13e0ec29
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•