788051 - [socorro-crashstats] implement pagination

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Robert Helmer [:rhelmer]]

I have aped the hangreport implementation in https://github.com/mozilla/socorro-crashstats/pull/66, once that lands I think it's time to uplift that macro into the base template.

However, it is missing (at least) one feature that the old one has - once the page count gets too high, an ellipsis is shown. This is unlikely to matter for /report/list and hangreport, but you can easily hit it for search:

https://crash-stats.mozilla.com/query/query?product=Firefox&version=Firefox%3A15.0&range_value=1&range_unit=weeks&date=08%2F30%2F2012+23%3A02%3A04&query_search=signature&query_type=contains&query=&reason=&build_id=&process_type=any&hang_type=any&do_query=1

Comment 1

[Robert Helmer [:rhelmer]]

I have this mostly done:

https://github.com/rhelmer/socorro-crashstats/compare/bug788051-pagination

* current pagination moved to base template
* ellipsis shown when count gets too high

I haven't finished fully implemented the pagination behavior on the old site, which looks like it's custom code and not using the standard kohana pagination:

if you are more than 6 pages and further than 2 from the end:
  it shows links for the +/- 2 pages around the current page

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to Robert Helmer [:rhelmer] from comment #1)
> if you are more than 6 pages and further than 2 from the end:
imts "less than 2 from the end"

Comment 3

[Robert Helmer [:rhelmer]]

r? https://github.com/mozilla/socorro-crashstats/pull/87

This includes some cleanup to make hangreport work (mostly because https://github.com/mozilla/socorro-crashstats/pull/67 has taken so long to land), those are separate commits so it should be readable hopefully...

Comment 4

[Robert Helmer [:rhelmer]]

landed in https://github.com/mozilla/socorro-crashstats/commit/085135d93a2d1eb0a2b96631b95cf1be1f122bc2