788087 - [Azure] Cairo surface patterns do not apply the pattern matrix

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

When a surface is used as a pattern the pattern matrix is not applied in DrawTargeCairo. This causes images to display incorrectly when using DrawTarget directly for example with Azure Cairo content.

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Apply pattern matrix when using a surface pattern.

Comment 2

[Mozilla RelEng Bot]

Try run for fec6e51fba98 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=fec6e51fba98
Results (out of 252 total builds):
    success: 231
    warnings: 16
    failure: 5
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-fec6e51fba98

Comment 3

[Joe Drew (not getting mail)]

Comment on attachment 657996 [details] [diff] [review]
Apply pattern matrix when using a surface pattern.

The fact that the matrix is inverted is due to us being in device space, correct? Probably deserves a comment.

Comment 4

[Behdad Esfahbod]

From cairo docs of cairo_pattern_set_matrix:

 * Important: Please note that the direction of this transformation 
 * matrix is from user space to pattern space. This means that if you 
 * imagine the flow from a pattern to user space (and on to device 
 * space), then coordinates in that flow will be transformed by the 
 * inverse of the pattern matrix.

Comment 5

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Apply pattern matrix when using a surface pattern v2 (with comments)

Comment 6

[Joe Drew (not getting mail)]

Comment on attachment 658270 [details] [diff] [review]
Apply pattern matrix when using a surface pattern v2 (with comments)

Review of attachment 658270 [details] [diff] [review]:
-----------------------------------------------------------------

when I r+ I don't need to see it again :)

Comment 7

[Mozilla RelEng Bot]

Try run for fec6e51fba98 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=fec6e51fba98
Results (out of 257 total builds):
    success: 234
    warnings: 17
    failure: 6
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-fec6e51fba98

Comment 8

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Patch has changed since try push but only comments.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

(In reply to Mozilla RelEng Bot from comment #7)
>     https://tbpl.mozilla.org/?tree=Try&rev=fec6e51fba98

Green on Try.

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc9be79a2eeb

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bc9be79a2eeb