[Azure] Cairo surface patterns do not apply the pattern matrix

RESOLVED FIXED in mozilla18

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: kentuckyfriedtakahe, Assigned: kentuckyfriedtakahe)

Tracking

unspecified
mozilla18
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

When a surface is used as a pattern the pattern matrix is not applied in DrawTargeCairo. This causes images to display incorrectly when using DrawTarget directly for example with Azure Cairo content.
Created attachment 657996 [details] [diff] [review]
Apply pattern matrix when using a surface pattern.
QA Contact: ajones

Comment 2

6 years ago
Try run for fec6e51fba98 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=fec6e51fba98
Results (out of 252 total builds):
    success: 231
    warnings: 16
    failure: 5
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-fec6e51fba98
Attachment #657996 - Flags: review?(joe)
Comment on attachment 657996 [details] [diff] [review]
Apply pattern matrix when using a surface pattern.

The fact that the matrix is inverted is due to us being in device space, correct? Probably deserves a comment.
Attachment #657996 - Flags: review?(joe) → review+

Comment 4

6 years ago
From cairo docs of cairo_pattern_set_matrix:

 * Important: Please note that the direction of this transformation 
 * matrix is from user space to pattern space. This means that if you 
 * imagine the flow from a pattern to user space (and on to device 
 * space), then coordinates in that flow will be transformed by the 
 * inverse of the pattern matrix.
Created attachment 658270 [details] [diff] [review]
Apply pattern matrix when using a surface pattern v2 (with comments)
Attachment #658270 - Flags: review?(joe)
Attachment #658270 - Flags: review?(joe)
Attachment #657996 - Attachment is obsolete: true
Comment on attachment 658270 [details] [diff] [review]
Apply pattern matrix when using a surface pattern v2 (with comments)

Review of attachment 658270 [details] [diff] [review]:
-----------------------------------------------------------------

when I r+ I don't need to see it again :)
Attachment #658270 - Flags: review+

Comment 7

6 years ago
Try run for fec6e51fba98 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=fec6e51fba98
Results (out of 257 total builds):
    success: 234
    warnings: 17
    failure: 6
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-fec6e51fba98
Patch has changed since try push but only comments.
Keywords: checkin-needed
(In reply to Mozilla RelEng Bot from comment #7)
>     https://tbpl.mozilla.org/?tree=Try&rev=fec6e51fba98

Green on Try.

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc9be79a2eeb
Assignee: nobody → ajones
Flags: in-testsuite-
Keywords: checkin-needed
QA Contact: ajones
https://hg.mozilla.org/mozilla-central/rev/bc9be79a2eeb
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.