788119 - Don't even parse home pages in Reader's worker thread

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Reader View, defect, P1)

Description

[Lucas Rocha (:lucasr)]

We're currently parsing the page to then discard it just after causing unnecessary overhead (CPU and memory).

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Don't even parse home pages in Reader's worker thread

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 658038 [details] [diff] [review]
Don't even parse home pages in Reader's worker thread

As we talked about, maybe we should move the check and the protocol check into a separate function and call that method. That way we can easily add the check to any API.

Comment 3

[Lucas Rocha (:lucasr)]

Pushed with suggested changes:
https://hg.mozilla.org/integration/mozilla-inbound/rev/95b911e4e435

Comment 4

[Lucas Rocha (:lucasr)]

Comment on attachment 658038 [details] [diff] [review]
Don't even parse home pages in Reader's worker thread

[Approval Request Comment]
User impact if declined: Unnecessary CPU and memory overhead on pages that we don't really want to do anything about regarding readability. Starting the web worker and parsing the document is not a cheap operation. We should avoid it whenever possible.
Testing completed (on m-c, etc.): Local testing, trivial patch.
Risk to taking this patch (and alternatives if risky): Trivial patch, very low risk.
String or UUID changes made by this patch: None.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/95b911e4e435

Comment 6

[Lucas Rocha (:lucasr)]

Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/429aeed563bf

Pushed to beta:
https://hg.mozilla.org/releases/mozilla-beta/rev/294df682af4c

Comment 7

[Cristian Nicolae (:xti)]

This issue is fixed on the latest Nightly and Aurora builds. Closing bug as verified fixed on:

Firefox 18.0a1 (2012-09-12)
Device: Galaxy Note
OS: Android 4.0.4

Comment 8

[Adrian Tamas (:AdrianT)]

Home page is not parsed on Firefox Mobile 16.0b5 on Samsung Galaxy R (Android 2.3.4). The message "Reader: Not parsing home page:" can be found in the logs when loading the home page of a website. Marking as verified on Firefox Mobile 16.