788149 - Empty dictionary for worker objects

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: test

Applying the attached patch, this is the output that I see:

TEST_PATH=dom/workers/test/test_xhr_params.html  make -C ../build/ mochitest-plain

BAKU CONSTRUCTOR: 1 0
TEST-PASS | unknown test url | XHR exists!
TEST-PASS | unknown test url | mozAnon == true - true should equal true
...

Then, refreshing the page:

BAKU CONSTRUCTOR: 0 0
TEST-PASS | unknown test url | XHR exists!
TEST-UNEXPECTED-FAIL | unknown test url | mozAnon == true - got false, expected true
...

The MozXMLHttpRequestParametersWorkers seems empty:
printf("BAKU CONSTRUCTOR: %d %d\n", aParams.mozAnon, aParams.mozSystem);

Comment 1

[Boris Zbarsky [:bzbarsky]]

Stepping through this on the reload, I see:

    JS_HasPropertyById(cx, &val.toObject(), mozAnon_id, &found)

  (gdb) p found
  $1 = 0

I wonder...  We end up with separate jsruntimes for the different workers, don't we?  So we can't actually use jsid here, I bet.  :(

Comment 2

[Andrea Marchesini [:baku]]

yep, Any worker has a separated JSRuntime.

Any implication using JS_HasProperty(JSContext *cx, JSObject *obj, const char *name, JSBool *foundp) ?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Well, yes, it's slower.  ;)

Patch coming up to do just that on workers, though.  I'll include a variant of the attached test that fails reliably without requiring a reload.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Actually, maybe it's better to just land the test as part of bug 761227.  I'll just attach a diff against the test patch in this bug.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Test that fails reliably

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Don't use jsids in worker code in bindings, because those are runtime-specific and workers can run on multiple runtimes.

Comment 7

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/73642fc72b2e

Still needs a test, but I assume that will land as part of bug 761227?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/73642fc72b2e