788181 - xhr instanceof XMLHttpRequest == false in workers

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Andrea Marchesini [:baku]]

var xhr = new XMLHttpRequest();
  if(xhr instanceof XMLHttpRequest) ...

should be true.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: mochitest

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix instanceof for XHR and XHR.upload in workers.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Peter, do you think this is worth backporting to aurora or beta?

Comment 4

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d10e508e4890

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 658119 [details] [diff] [review]
Fix instanceof for XHR and XHR.upload in workers.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 740069
User impact if declined: Some scripts in workers will get incorrect instanceof
   values, which may cause some pages using workers to break.
Testing completed (on m-c, etc.): Passes attached tests.
Risk to taking this patch (and alternatives if risky): Risk is low.
String or UUID changes made by this patch: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d10e508e4890

Comment 7

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1f774f8fdfe4
https://hg.mozilla.org/releases/mozilla-beta/rev/c069535ea457