Closed Bug 788211 Opened 12 years ago Closed 12 years ago

Fix a few bugs in CGDOMJSProxyHandler_defineProperty

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
      No description provided.
Attachment #658154 - Flags: review?(bzbarsky)
Comment on attachment 658154 [details] [diff] [review]
Patch v1

r=me
Attachment #658154 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/4e6c53859f89
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Comment on attachment 658154 [details] [diff] [review]
Patch v1

Review of attachment 658154 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Codegen.py
@@ +4643,5 @@
>                      CGIndenter(CGProxyNamedGetter(self.descriptor)).define() +
>                      "  if (found) {\n"
>                      "    return ThrowErrorMessage(cx, MSG_NO_PROPERTY_SETTER, \"%s\");\n" +
>                      "  }\n" +
> +                    "  return true;\n"

peterv contested this; I filed https://www.w3.org/Bugs/Public/show_bug.cgi?id=18908
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: