788253 - Add a way for users to send feedback

Status: VERIFIED FIXED

(Marketplace Graveyard :: General, defect, P4)

Description

[Wil Clouser [:clouserw]]

We'd like to add a form that would let people easily give us feedback about the marketplace.  Please add a link under the settings menu called "Give Feedback" which opens a form (a lightbox is fine) with a textarea for comments and two buttons, submit and cancel.

On the backend, this should simply send an email to [e-mail].  Please include some relevant data at the bottom of the email.  User id, name, email, and user agent come to mind.  Anything else you think appropriate.

Thanks!

Comment 1

[Rob Hudson [:robhudson]]

I've written this before myself. I'd be happy to write again. It's pretty simple. I included the current URL path and any logged in user info I had as well. E.g. if they're providing feedback about something on the page, you at least know which page they were on.

In the UI, I implemented it as a faded out textarea that when clicked, expanded a bit and showed the form submit button, with placeholder text of something like "Send Feedback". But link + lightbox or modal would work just as well.

Comment 2

[Maria Sandberg [:mushi]]

Rob - is this something you are working on? I can provide you some basic wireframes if  that would help.

Comment 3

[Rob Hudson [:robhudson]]

Wireframes would be great. I'll likely do this after the packaged app work is completed.

Comment 4

[Maria Sandberg [:mushi]]

Attachment: .pdf - feedback tab

Here are the wireframes, let me know if you have questions. Attaching a visual design too. Asking Wil to file separate bugs for the other changes if he feels that's needed.

Comment 5

[Maria Sandberg [:mushi]]

Attachment: .psd updated settings

Comment 6

[Maria Sandberg [:mushi]]

cc:ing Ibai for any SUMO related questions on deep links or other things that might come up.

Comment 7

[Christopher Van Wiemeersch [:cvan]]

For people who don't want to fire up Photoshop or Preview.app: http://f.cl.ly/items/2V0e2M1z30273E2c0t22/Settings-beta.jpg

Comment 8

[Rob Hudson [:robhudson]]

Should this be available to logged out users?

If not, the email box in the mocks can probably be skipped and just have a single textarea for comments. We automatically include the user's info in the message we send.

Comment 9

[Christopher Van Wiemeersch [:cvan]]

(In reply to Rob Hudson [:robhudson] from comment #8)
> Should this be available to logged out users?

Well, the walled garden is still enabled. If this should be available for anonymous users, then we'll need to use a recaptcha solution like we do for Report Abuse. I'd just implement this for authenticated users for now, but I'll let real people answer that.

> If not, the email box in the mocks can probably be skipped and just have a
> single textarea for comments. We automatically include the user's info in
> the message we send.

Comment 10

[:ibai]

We may want to use the feedback process as and extra incentive to register, so I will say that this is only available for registered users and perhaps register those who are trying to send feedback without being logged? (after asking for permission).

Comment 11

[Maria Sandberg [:mushi]]

The walled garden is coming down so we can't assume that the user is logged in. Can we prompt for sign in on submit like Ibai suggested? Nav.id goodness?

Comment 12

[Wil Clouser [:clouserw]]

When I filed this I said only a textarea because Maria said the email input wasn't necessary.  The form should only be usable by people who are logged in (asking for log in on the page is fine - just don't lose what people typed or they'll get more upset)

Comment 13

[Christopher Van Wiemeersch [:cvan]]

(In reply to Wil Clouser [:clouserw] from comment #12)
> When I filed this I said only a textarea because Maria said the email input
> wasn't necessary.  The form should only be usable by people who are logged
> in (asking for log in on the page is fine - just don't lose what people
> typed or they'll get more upset)

Yeah, use localStorage. For a possible alternative, see what I did for logging in for developer submission (as an anonymous user go to https://marketplace.mozilla.org/developers/submit/app/).

Comment 14

[:ibai]

It's all good.

We need their address to contact them back if there's a need for a follow up email.

Comment 15

[Christopher Van Wiemeersch [:cvan]]

(In reply to :ibai from comment #14)
> It's all good.
> 
> We need their address to contact them back if there's a need for a follow up
> email.

We'll have the user's email if he/she logged in using Persona (on Desktop/Android). On Firefox OS supposedly there's no email so yeah.

Comment 16

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/bc17c78

Comment 17

[Rob Hudson [:robhudson]]

Follow up clean-up commit
https://github.com/mozilla/zamboni/commit/3c7922a

Comment 18

[Cristian Boldan]

Verified as fixed in https://marketplace-dev.allizom.org/settings/feedback on FF18 (Win 7)
Postfix screencast http://screencast.com/t/OsR3L0xZS0Mk
Closing bug.

Comment 19

[Maria Sandberg [:mushi]]

Could we get the "clear" button from the mocks in there? The submit button should also be smaller. 

I'd love to get this behavior:
When the user enters the page, the text field is empty and a (smaller) submit button sits at the bottom right of the text field. When the user starts typing, a secondary-styled "clear" button shows up (as placed in mocks). Hitting it should clear the text field. 

So - "clear" button only shows when there are >=1 char in the text field.

Comment 20

[Christopher Van Wiemeersch [:cvan]]

(In reply to Maria Sandberg [:mushi] from comment #19)
> Could we get the "clear" button from the mocks in there?

I accidentally click "Clear" buttons and clear my text all the time. I'm not certain what the use case is here. If there was more than one field, I'd be inclined to say yes. But clearing one field is a trivial task.

> The submit button
> should also be smaller.

This is what it looks like on production: http://cl.ly/image/1O131Z0b3c1o

We were having push issues and serving stale CSS on production.

> 
> I'd love to get this behavior:
> When the user enters the page, the text field is empty and a (smaller)
> submit button sits at the bottom right of the text field. When the user
> starts typing, a secondary-styled "clear" button shows up (as placed in
> mocks). Hitting it should clear the text field. 
> 
> So - "clear" button only shows when there are >=1 char in the text field.

Comment 21

[Maria Sandberg [:mushi]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #20)
> (In reply to Maria Sandberg [:mushi] from comment #19)
> > Could we get the "clear" button from the mocks in there?
> 
> I accidentally click "Clear" buttons and clear my text all the time. I'm not
> certain what the use case is here. If there was more than one field, I'd be
> inclined to say yes. But clearing one field is a trivial task.

The clear button is intended as an alternative to "cancel" which wouldn't make sense on this page. If I change my mind and no longer want to submit it's not apparent to me that the field will clear if I go "back", and clearing the field in one click is getting at the "I changed my mind, abort" option normally covered by a "cancel" button. Happy to user test it once it's there to see if it causes accidental clearings.

Comment 22

[Christopher Van Wiemeersch [:cvan]]

In the future, could you please file new bugs? We try to never reopen VERIFIED FIXED bugs.

Comment 23

[Maria Sandberg [:mushi]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #22)
> In the future, could you please file new bugs? We try to never reopen
> VERIFIED FIXED bugs.

Sure thing - nobody gave me the bugzilla etiquette class.

Comment 24

[Cristian Boldan]

Verified as fixed in https://marketplace-dev.allizom.org/settings/feedback on FF18 (Win 7)
Postfix screencast http://screencast.com/t/YfPnDHATzaF
Closing bug.