788268 - Device Storage - Convert tests to use public types

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Doug Turner (:dougt)]

Currently we are using a special Device Storage type named "testing" and "testing-other".  We only use this for testing as it gives us a way to clean up and not have to deal with real media files on peoples machines.  The problem with this approach is that we can't really test what we are shipping.  I want to add type filtering and using "testing" doesn't really work for us

There is a better way.

Instead, we should just make all of the device storage object returned during testing point to the temp directory.  This allows us to filter based on device storage type.  it also allows us to test more of the code that we are shipping.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Dave Hylands [:dhylands]]

Attachment: Sound of a camera motor which doesn't show up in the play list

file shows this file as:

101223NikonFEMotor.mp3: Audio file with ID3 version 2.3.0, contains: MPEG ADTS, layer III, v1, 128 kbps, 44.1 kHz, Monaural

Comment 3

[Dave Hylands [:dhylands]]

I also noticed that the .ogg files which were included in the media samples didn't show up.

Comment 4

[Dave Hylands [:dhylands]]

After adding/removing some more files the attached mp3 file showed up, so I'm not sure what's going on.

Comment 5

[Doug Turner (:dougt)]

dave, wrong bug.  you're looking for 786922

Comment 6

[Doug Turner (:dougt)]

https://hg.mozilla.org/mozilla-central/rev/14ea11f7a22a

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Backed out for orange

https://hg.mozilla.org/mozilla-central/rev/fd4d9c386f97

Comment 8

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/db0d30f0f498

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/db0d30f0f498