Closed Bug 788268 Opened 7 years ago Closed 7 years ago

Device Storage - Convert tests to use public types

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18
Tracking Status
firefox18 --- fixed

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(2 files)

Currently we are using a special Device Storage type named "testing" and "testing-other".  We only use this for testing as it gives us a way to clean up and not have to deal with real media files on peoples machines.  The problem with this approach is that we can't really test what we are shipping.  I want to add type filtering and using "testing" doesn't really work for us

There is a better way.

Instead, we should just make all of the device storage object returned during testing point to the temp directory.  This allows us to filter based on device storage type.  it also allows us to test more of the code that we are shipping.
Attached patch patch v.1Splinter Review
Attachment #658305 - Flags: review?(bent.mozilla)
file shows this file as:

101223NikonFEMotor.mp3: Audio file with ID3 version 2.3.0, contains: MPEG ADTS, layer III, v1, 128 kbps, 44.1 kHz, Monaural
I also noticed that the .ogg files which were included in the media samples didn't show up.
After adding/removing some more files the attached mp3 file showed up, so I'm not sure what's going on.
dave, wrong bug.  you're looking for 786922
Attachment #658305 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/14ea11f7a22a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Backed out for orange

https://hg.mozilla.org/mozilla-central/rev/fd4d9c386f97
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/db0d30f0f498
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.