The default bug view has changed. See this FAQ.

Fix TLS detection with clang on OpenBSD (port bug 778414)

RESOLVED FIXED in Thunderbird 18.0

Status

MailNews Core
Build Config
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: gaston, Assigned: gaston)

Tracking

unspecified
Thunderbird 18.0
x86
OpenBSD

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Atm configuring c-c with clang on OpenBSD wrongly thinks openbsd supports TLS, while it doesn't (see https://bugzilla.mozilla.org/show_bug.cgi?id=778414#c0).

$grep HAVE_THREAD_TLS_KEYWORD /usr/obj/c-c/* 
/usr/obj/c-c/comm-config.h:#define HAVE_THREAD_TLS_KEYWORD 1

It builds but fails linking libxul.so :

../../../mailnews/imap/src/nsSyncRunnableHelpers.o(.text._ZN12_GLOBAL__N_120DispatchSyncRunnableEPNS_16SyncRunnableBaseE+0xa): In function `(anonymous namespace)::Dispatc
hSyncRunnable((anonymous namespace)::SyncRunnableBase*)':
../../../mozilla/dist/include/nsAtomicRefcnt.h:46: undefined reference to `gTLSThreadID'
../../../mailnews/addrbook/src/nsAbManager.o(.text._ZN11nsAbManager4InitEv+0x10): In function `nsAbManager::Init()':
../../../mozilla/dist/include/mozilla/HashFunctions.h:65: undefined reference to `gTLSThreadID'
../../../ldap/xpcom/src/nsLDAPSyncQuery.o(.text._ZN15nsLDAPSyncQuery14InitConnectionEv+0x1a): In function `nsLDAPSyncQuery::InitConnection()':
/home/landry/src/comm-central/ldap/xpcom/src/nsLDAPSyncQuery.cpp:163: undefined reference to `gTLSThreadID'
^N/usr/bin/ld: libxul.so.1.0: hidden symbol `gTLSThreadID' isn't defined
clang-3: error: linker command failed with exit code 1 (use -v to see invocation)

We should port the configure.in chunk of https://bug778414.bugzilla.mozilla.org/attachment.cgi?id=646831 to c-c to fix that.
(Assignee)

Comment 1

5 years ago
Created attachment 658219 [details] [diff] [review]
OpenBSD doesn't support TLS yet
Assignee: nobody → landry
Attachment #658219 - Flags: review?(mbanner)
Comment on attachment 658219 [details] [diff] [review]
OpenBSD doesn't support TLS yet

Sorry for the delay. r=me
Attachment #658219 - Flags: review?(mbanner) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/comm-central/rev/c3caa58362dc
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
You need to log in before you can comment on or make changes to this bug.