788356 - Valgrind detects leak at calloc, NewContext, Evaluate (8 bytes in 1 blocks are definitely lost)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: Valgrind stack

evaluate("",{newContext:true})

shows a Valgrind leak on js opt shell on m-c changeset 7c75cd38626a without any CLI arguments at calloc

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   94274:648093316d93
user:        Jason Orendorff
date:        Thu May 17 18:54:30 2012 -0500
summary:     Bug 755808 - Add more options to JS shell evaluate() function. r=jimb.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

Comment 2

[Jason Orendorff [:jorendorff]]

I meant to add: Thanks, Gary. Does this fix it?

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to Jason Orendorff [:jorendorff] from comment #2)
> I meant to add: Thanks, Gary. Does this fix it?

Yes, it does, thanks for the quick patch!

Comment 4

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e38d70105ba3

Comment 5

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/e38d70105ba3