788359 - Remove unused cvtargs functionality.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: v0

It's silly to have this much fiddly code sitting around completely unused and untested.

Comment 1

[David Mandelin [:dmandelin]]

Thanks for sending me the review, Jeff.

Hmmm...this feature doesn't look terribly important, but before taking it out, please do at least due diligence of proposing it to the newsgroup to at least give someone the chance of saying they would be highly affected.

Comment 2

[Jeff Walden [:Waldo]]

That was Terrence, not me.  :-)  He poked me at it originally, but I figured as a JSAPI thing you were probably a better person, and all that.

Comment 3

[David Mandelin [:dmandelin]]

(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #2)
> That was Terrence, not me.  :-)  He poked me at it originally, but I figured
> as a JSAPI thing you were probably a better person, and all that.

I know, and that's why I was thanking you. Feel free to weigh in, btw.

Comment 4

[David Mandelin [:dmandelin]]

Comment on attachment 658308 [details] [diff] [review]
v0

Review of attachment 658308 [details] [diff] [review]:
-----------------------------------------------------------------

Crickets on the ng => cleared for deletion. :-)

Comment 5

[Terrence Cole [:terrence]]

Green try run at:
https://tbpl.mozilla.org/?tree=Try&rev=256ec9cb6458

Checked in at:
https://hg.mozilla.org/integration/mozilla-inbound/rev/46ac1ff1dca2

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/46ac1ff1dca2