788400 - Correlate samples with video frames

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: Part 1: Add frame counter

By adding frame count markers in the profile and tagging frames with a number we can correlate samples with video captures.

Comment 1

[Benoit Girard (:BenWa)]

Attachment: screenshot

Comment 2

[Benoit Girard (:BenWa)]

Attachment: Part 2: Add a frame number to profiles

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 658372 [details] [diff] [review]
Part 1: Add frame counter

Actually I should get a GFX peer to review this.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 658372 [details] [diff] [review]
Part 1: Add frame counter

Review of attachment 658372 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/opengl/LayerManagerOGL.cpp
@@ +537,5 @@
> +      context->fClearColor(0.0, 0.0, 0.0, 0.0);
> +    } else {
> +      context->fClearColor(1.0, 1.0, 1.0, 0.0);
> +    }
> +    context->fClear(LOCAL_GL_COLOR_BUFFER_BIT);

Add a comment about how this should probably be implemented with a single draw instead of multiple ones.

Comment 5

[Benoit Girard (:BenWa)]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #4)
> Comment on attachment 658372 [details] [diff] [review]
> Part 1: Add frame counter
> 
> Review of attachment 658372 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/layers/opengl/LayerManagerOGL.cpp
> @@ +537,5 @@
> > +      context->fClearColor(0.0, 0.0, 0.0, 0.0);
> > +    } else {
> > +      context->fClearColor(1.0, 1.0, 1.0, 0.0);
> > +    }
> > +    context->fClear(LOCAL_GL_COLOR_BUFFER_BIT);
> 
> Add a comment about how this should probably be implemented with a single
> draw instead of multiple ones.

+    // We should do this using a single draw call
+    // instead of 16 glClear()

Comment 6

[Benoit Girard (:BenWa)]

Attachment: Part 1: Add frame counter

Comment 7

[Benoit Girard (:BenWa)]

Attachment: Part 1: Add frame counter (rebase)

Comment 8

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9000cfd0f51a
https://hg.mozilla.org/integration/mozilla-inbound/rev/308fd7da03e6

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9000cfd0f51a
https://hg.mozilla.org/mozilla-central/rev/308fd7da03e6