788401 - Avoid warnings in EventUtils.synthesizeWheel()

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

In the test log, there are some warnings:

> JavaScript strict warning: chrome://mochikit/content/tests/SimpleTest/EventUtils.js, line 310: reference to undefined property aEvent.deltaX

> JavaScript strict warning: chrome://mochikit/content/tests/SimpleTest/EventUtils.js, line 314: reference to undefined property aEvent.deltaY

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 658377 [details] [diff] [review]
Patch

Do we need to change aEvent.lineOrPageDeltaX != null too?
I mean, is it possible that aEvent.lineOrPageDeltaX is undefined, and would
that cause a warning?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Olli Pettay [:smaug] from comment #2)
> Do we need to change aEvent.lineOrPageDeltaX != null too?

Hmm, I guess it's not problem because it's checking the fact but I'll check it later.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Smaug:

It's not a problem, browser_overflowScroll.js calls it only with deltaX and deltaMode. However, there is no warnings with this patch:

https://tbpl.mozilla.org/php/getParsedLog.php?id=15002058&tree=Try&full=1
https://tbpl.mozilla.org/php/getParsedLog.php?id=15003870&tree=Try&full=1
https://tbpl.mozilla.org/php/getParsedLog.php?id=15003290&tree=Try&full=1

This patch makes the method simpler than the previous patch. I'd like to use this instead.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/211a7f7cae85

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/211a7f7cae85