Closed Bug 788498 Opened 8 years ago Closed 8 years ago

add tbpl code for chromez suite

Categories

(Tree Management Graveyard :: TBPL, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jmaher, Assigned: emorley)

References

Details

Attachments

(1 file)

we had to switch chromer to be chromez when adding tresize into the suite.  This is showing up as a 'T' on tbpl and should be a 'c'
I presume branches are still running chromer, so we need both, not just s/chromer/chromez/ right? :-)
yes, older branches have chromer, but both could have a 'c' letter.
We currently have all of the variants:
    /talos.*chrome(_mac)?(\.2)?(r)?$/i.test(name) ? "Talos chrome" :

Mapping to:
    "Talos chrome" : "c",

So presuming we are happy lumping chromez in with the others, we should just need to:
    s/(r)?/(r|z)?/
Attached patch Patch v1Splinter Review
Tested locally and looks good :-)
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attachment #658857 - Flags: review?(jmaher)
Comment on attachment 658857 [details] [diff] [review]
Patch v1

Review of attachment 658857 [details] [diff] [review]:
-----------------------------------------------------------------

looks good to me.
Attachment #658857 - Flags: review?(jmaher) → review+
Checked in:


(But as normal, needs a push to prod; which is currently blocked on making sure bug 718632 is working as expected, now that we fixed the server dependency problems).
(In reply to Ed Morley [:edmorley] from comment #6)
> Checked in:

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/8f3bcd650aeb
Depends on: 790559
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.