Closed
Bug 788498
Opened 13 years ago
Closed 13 years ago
add tbpl code for chromez suite
Categories
(Tree Management Graveyard :: TBPL, defect)
Tree Management Graveyard
TBPL
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: emorley)
References
Details
Attachments
(1 file)
|
1.38 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
we had to switch chromer to be chromez when adding tresize into the suite. This is showing up as a 'T' on tbpl and should be a 'c'
| Assignee | ||
Comment 1•13 years ago
|
||
I presume branches are still running chromer, so we need both, not just s/chromer/chromez/ right? :-)
| Reporter | ||
Comment 2•13 years ago
|
||
yes, older branches have chromer, but both could have a 'c' letter.
| Assignee | ||
Comment 3•13 years ago
|
||
We currently have all of the variants:
/talos.*chrome(_mac)?(\.2)?(r)?$/i.test(name) ? "Talos chrome" :
Mapping to:
"Talos chrome" : "c",
So presuming we are happy lumping chromez in with the others, we should just need to:
s/(r)?/(r|z)?/
| Assignee | ||
Comment 4•13 years ago
|
||
Tested locally and looks good :-)
| Reporter | ||
Comment 5•13 years ago
|
||
Comment on attachment 658857 [details] [diff] [review]
Patch v1
Review of attachment 658857 [details] [diff] [review]:
-----------------------------------------------------------------
looks good to me.
Attachment #658857 -
Flags: review?(jmaher) → review+
| Assignee | ||
Comment 6•13 years ago
|
||
Checked in:
(But as normal, needs a push to prod; which is currently blocked on making sure bug 718632 is working as expected, now that we fixed the server dependency problems).
| Assignee | ||
Comment 7•13 years ago
|
||
(In reply to Ed Morley [:edmorley] from comment #6)
> Checked in:
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/8f3bcd650aeb
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: Webtools → Tree Management
Updated•10 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•