788561 - SettingsAPI: Use createLock instead of getLock

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Comment 1

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 658527 [details] [diff] [review]
patch

I think you should remove getLock. That will force everyone to reexamine their code for excessive transactions.

Comment 3

[Gregor Wagner [:gwagner]]

(In reply to ben turner [:bent] from comment #2)
> Comment on attachment 658527 [details] [diff] [review]
> patch
> 
> I think you should remove getLock. That will force everyone to reexamine
> their code for excessive transactions.

I will, but first we have to change gaia. We can't land both fixes at the same time :(

Comment 4

[Gregor Wagner [:gwagner]]

Comment on attachment 658527 [details] [diff] [review]
patch

https://tbpl.mozilla.org/?tree=Try&rev=94f366488e33

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 658527 [details] [diff] [review]
patch

Review of attachment 658527 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me if this passes try!

Comment 6

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/195a99db216a

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/195a99db216a