Closed
Bug 788561
Opened 13 years ago
Closed 13 years ago
SettingsAPI: Use createLock instead of getLock
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: gwagner, Assigned: gwagner)
Details
Attachments
(1 file)
|
36.93 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•13 years ago
|
||
Comment on attachment 658527 [details] [diff] [review]
patch
I think you should remove getLock. That will force everyone to reexamine their code for excessive transactions.
|
|
Assignee | |
Comment 3•13 years ago
|
||
(In reply to ben turner [:bent] from comment #2)
> Comment on attachment 658527 [details] [diff] [review]
> patch
>
> I think you should remove getLock. That will force everyone to reexamine
> their code for excessive transactions.
I will, but first we have to change gaia. We can't land both fixes at the same time :(
|
|
Assignee | |
Comment 4•13 years ago
|
||
Comment on attachment 658527 [details] [diff] [review]
patch
https://tbpl.mozilla.org/?tree=Try&rev=94f366488e33
Attachment #658527 -
Flags: review?(bent.mozilla)
Comment on attachment 658527 [details] [diff] [review]
patch
Review of attachment 658527 [details] [diff] [review]:
-----------------------------------------------------------------
rs=me if this passes try!
Attachment #658527 -
Flags: review?(bent.mozilla) → review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
|
||
Comment 7•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•