Closed Bug 788561 Opened 7 years ago Closed 7 years ago

SettingsAPI: Use createLock instead of getLock

Categories

(Core :: DOM: Device Interfaces, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: gwagner, Assigned: gwagner)

Details

Attachments

(1 file)

No description provided.
Attached patch patchSplinter Review
Comment on attachment 658527 [details] [diff] [review]
patch

I think you should remove getLock. That will force everyone to reexamine their code for excessive transactions.
(In reply to ben turner [:bent] from comment #2)
> Comment on attachment 658527 [details] [diff] [review]
> patch
> 
> I think you should remove getLock. That will force everyone to reexamine
> their code for excessive transactions.

I will, but first we have to change gaia. We can't land both fixes at the same time :(
Comment on attachment 658527 [details] [diff] [review]
patch

Review of attachment 658527 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me if this passes try!
Attachment #658527 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/195a99db216a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.