Closed Bug 788585 Opened 12 years ago Closed 5 years ago

Pause on exceptions probably interferes with 'step', 'next', and 'finish'

Categories

(DevTools :: Debugger, defect, P3)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jimb, Unassigned)

References

Details

ThreadClient#pauseOnExceptions probably doesn't work when the debuggee is running, even if ThreadClient#interrupt did (bug 788578). If the debuggee is running, pauseOnExceptions interrupts it, and then resumes it with a 'resume' packet with an appropriate pauseOnExceptions property. However, if the original 'resume' packet that had set the debuggee running in the first place had a resumeLimit property, the 'resume' packet sent by ThreadClient#pauseOnExceptions will be missing that resumeLimit.
OS: Linux → All
Hardware: x86_64 → All
Good catch! Although in most cases stepping will return to the paused state before the user has a chance to click on the pauseOnExceptions checkbox, it is indeed a bug. Bug 755661 (Part 2) adds a _resumeLimit property to the thread client that can be used to fix this issue.
Depends on: 755661
Priority: -- → P2
filter on BLACKEAGLE.
Priority: P2 → P3
Summary: ThreadClient.prototype.pauseOnExceptions probably interferes with 'step', 'next', and 'finish' → Pause on exceptions probably interferes with 'step', 'next', and 'finish'
Product: Firefox → DevTools

I believe this is fixed now.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.