788613 - configure should tail config.log on failure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

When configure fails config.log usually has the information you need to figure out exactly what went wrong. However, that's not displayed. If you're doing a local build that's fine, but if your build fails on tinderbox it's really frustrating. We should make configure spit out the tail of config.log when it fails.

Comment 1

[Gregory Szorc [:gps]]

As said in IRC, tail will likely just print a variable dump. We should probably just dump the entire file.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Dump config.log when configure fails

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 732711 [details] [diff] [review]
Dump config.log when configure fails

Review of attachment 732711 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/autoconf/hooks.m4
@@ +5,5 @@
> +dnl Output the contents of config.log when configure exists with an
> +dnl error code.
> +define([MOZ_CONFIG_LOG_TRAP],
> +[changequote(<<<, >>>)dnl
> +trap '[ "$?" != 0 ] && echo "------ config.log ------" && cat config.log' EXIT

Do we want to cat all of config.log here, or should we just tail the last 20 lines or so?

Comment 4

[Mike Hommey [:glandium]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> Comment on attachment 732711 [details] [diff] [review]
> Dump config.log when configure fails
> 
> Review of attachment 732711 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: build/autoconf/hooks.m4
> @@ +5,5 @@
> > +dnl Output the contents of config.log when configure exists with an
> > +dnl error code.
> > +define([MOZ_CONFIG_LOG_TRAP],
> > +[changequote(<<<, >>>)dnl
> > +trap '[ "$?" != 0 ] && echo "------ config.log ------" && cat config.log' EXIT
> 
> Do we want to cat all of config.log here, or should we just tail the last 20
> lines or so?

I was considering writing a little script to get the n lines from the last occurrence of "^configure:[0-9]+:"

Comment 5

[Mike Hommey [:glandium]]

Attachment: Dump config.log when configure fails

with tail -n 25 (arbitrary length, that fills a default terminal size)

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3361cd2e967

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Backed out for breaking my build.

https://hg.mozilla.org/integration/mozilla-inbound/rev/61f0e35aab01

Comment 8

[Mike Hommey [:glandium]]

It breaks build/autoconf/acwinpaths.m4

Comment 9

[Mike Hommey [:glandium]]

Attachment: Dump config.log when configure fails.

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 734605 [details] [diff] [review]
Dump config.log when configure fails.

Review of attachment 734605 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/build/autoconf/hooks.m4
@@ +1,5 @@
> +dnl This Source Code Form is subject to the terms of the Mozilla Public
> +dnl License, v. 2.0. If a copy of the MPL was not distributed with this
> +dnl file, You can obtain one at http://mozilla.org/MPL/2.0/.
> +
> +dnl Output the contents of config.log when configure exists with an

exists?

Comment 11

[Mike Hommey [:glandium]]

Attachment: Dump config.log when configure fails.

Comment 12

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/32c37babc5bf

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/32c37babc5bf